-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add localized zh-Han* strings for Calendar #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add localized zh-Hans-CN strings for Calendar. File contents are duplicated from the zh-HANS-TW version.
Add localized zh-Hans strings for Calendar. According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays remains the same set of characters.
Add localized zh-Hant strings for Calendar. According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays remains the same set of characters.
Add localized zh-Hant-HK strings for Calendar. According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays remains the same set of characters.
You need to update |
Sorry for that, and thanks for notification~ On Thursday, July 18, 2013, Ryuichi Okumura wrote:
˳ף°²¿µ |
"zh-Hans", | ||
"zh-Hans-CN", | ||
"zh-Hant", | ||
"zh-Hant-HK", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not positive, but does Hant
need to be all uppercase here—HANT
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seems to be valid in RFC and IANA.
http://schneegans.de/lv/?tags=zh-Hans%0D%0Azh-Hans-CN%0D%0Azh-Hant%0D%0Azh-Hant-HK&format=text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okuryu do you think we should make these all uppercase simply for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericf No. The format of language tags are defined by RFC5646. These are different depending on languages, regions, and son. Some language tags composed of several subtags. Order of the subtags that are described are defined as [language]-[script]-[region]-[variant]-[extension]-[private]
, but all subtags not required. Also single language tag format like [language]
is valid. Therefore, the language tag called en
is valid as [language]
format, the language tag called en-US
is valid as [language]-[region]
format. zh-Hans
and zh-Hant
are comparable to [language]-[script]
format, zh-Hans-CN
and zh-Hans-HK
are comparable to [language]-[script]-[region]
format.
So I think these language tags are valid because they are registered in IANA Language Subtag Registry.
@ericf Sorry, I'm late. I hope that's what I should do in HISTORY.md. |
@ericf anything I can do else for this pull request? Thanks~ |
Merged this… |
Add localized zh-Han* (except zh-HANT-TW that already exists) strings for Calendar.
According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays should remains the same set of characters.