Fix Binding context in Y.Node.addMethod #1027 #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhiyelee This looks good, could you add a unit test for this before we merge it in? Thanks! |
|
@clarle ok,I will add it later. Thanks for your reply. |
|
@clarle hi, I have added the unit test. |
|
Looks great. Thanks for this fix! I guess I should see this in 3.11.1? |
ghost
assigned 
|
Merged #1070 with an additional assertion in the unit test into |
clarle
pushed a commit
that referenced
this pull request
Aug 14, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1027, context does not work in Y.Node.addMethod.