Skip to content

Ctrl + A and Ctrl + K should not be bound in macOS #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iwinux opened this issue Aug 6, 2020 · 2 comments
Closed

Ctrl + A and Ctrl + K should not be bound in macOS #1177

iwinux opened this issue Aug 6, 2020 · 2 comments

Comments

@iwinux
Copy link

iwinux commented Aug 6, 2020

VERSION: 0.43.3 on macOS 10.14.6

Currently there're at least two actions in note editor that are bound to modifier Ctrl and Command (Meta) on macOS, which is unnecessary and prevents the system level key bindings from working:

  1. Select All - bound to Ctrl + A and Command + A. Ctrl + A in macOS is supposed to be "move cursor to line start".

  2. Link - bound to Ctrl + K and Command + A. Ctrl + K in macOS is supposed to be "kill characters from cursor to line end".

It would be great if I can unbind these unwanted key bindings so that I can edit notes smoothly.

Related issues:

It seems weird that 3ff3021 does not resolve this issue.

@zadam
Copy link
Owner

zadam commented Aug 6, 2020

Hi, I think both of these are handled by ckeditor itself without any handling on trilium side so I guess this depends mainly on ckeditor/ckeditor5#5705

It seems weird that 3ff3021 does not resolve this issue.

The reason for this explicit handling were inputs not controlled by CKEditor, so removing that does not really affect the CKEditor's behavior ...

@oleq
Copy link

oleq commented Feb 23, 2021

Hi there, we addressed this issue in ckeditor/ckeditor5#5705. The fix will be included in the upcoming release of CKEditor 5. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants