Skip to content

Commit e8224bf

Browse files
vaverindavem330
authored andcommitted
net_failover: fixed rollback in net_failover_open()
found by smatch: drivers/net/net_failover.c:65 net_failover_open() error: we previously assumed 'primary_dev' could be null (see line 43) Fixes: cfc80d9 ("net: Introduce net_failover driver") Signed-off-by: Vasily Averin <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 241d46d commit e8224bf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/net_failover.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ static int net_failover_open(struct net_device *dev)
6161
return 0;
6262

6363
err_standby_open:
64-
dev_close(primary_dev);
64+
if (primary_dev)
65+
dev_close(primary_dev);
6566
err_primary_open:
6667
netif_tx_disable(dev);
6768
return err;

0 commit comments

Comments
 (0)