Skip to content

fix(images): support for insecure skip tls verify on image push/pull #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

fix(images): support for insecure skip tls verify on image push/pull #3725

merged 3 commits into from
Apr 24, 2025

Conversation

brandtkeller
Copy link
Member

Description

Fix support for images.Pull/Push honoring the --insecure-skip-tls-verify flag.

Related Issue

Fixes #3724

Relates to #

Checklist before merging

@brandtkeller brandtkeller self-assigned this Apr 23, 2025
@brandtkeller brandtkeller requested review from a team as code owners April 23, 2025 20:13
@netlify Netlify
Copy link

netlify bot commented Apr 23, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit bc11f4c
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/68095ba0c1d1bb0008afd528

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.41379% with 45 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/mirror.go 0.00% 11 Missing ⚠️
src/cmd/package.go 0.00% 9 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 9 Missing ⚠️
src/internal/packager2/layout/create.go 0.00% 8 Missing ⚠️
src/pkg/packager/creator/normal.go 0.00% 8 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/common.go 25.00% <ø> (ø)
src/internal/packager/images/pull.go 52.27% <100.00%> (+1.03%) ⬆️
src/internal/packager/images/push.go 55.55% <100.00%> (+1.93%) ⬆️
src/internal/packager2/layout/create.go 42.26% <0.00%> (-0.05%) ⬇️
src/pkg/packager/creator/normal.go 7.29% <0.00%> (-0.02%) ⬇️
src/cmd/package.go 49.46% <0.00%> (-0.06%) ⬇️
src/pkg/packager/deploy.go 5.71% <0.00%> (-0.02%) ⬇️
src/internal/packager2/mirror.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321
AustinAbro321 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtkeller brandtkeller added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit a0a0452 Apr 24, 2025
26 checks passed
@brandtkeller brandtkeller deleted the 3724_insecure_image_push branch April 24, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees

@brandtkeller brandtkeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image push does not honor --insecure-skip-tls-verify
2 participants
@brandtkeller @AustinAbro321