Skip to content

[Bug] Enum tracing breaks for serde > 1.0.210 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juntyr opened this issue Oct 25, 2024 · 2 comments · Fixed by #53
Closed

[Bug] Enum tracing breaks for serde > 1.0.210 #52

juntyr opened this issue Oct 25, 2024 · 2 comments · Fixed by #53
Labels
bug Something isn't working

Comments

@juntyr
Copy link

juntyr commented Oct 25, 2024

serde-rs/serde#2566 (comment)

TLDR: serde now includes enum variant aliases in the slice of variant names passed to deserialize_enum so there no longer is a 1-1 mapping from enum names to variants and the tracer tries out indices that are invalid

[sorry I'm a bit short on time right now]
@juntyr juntyr added the bug Something isn't working label Oct 25, 2024
@dtolnay dtolnay mentioned this issue Oct 28, 2024
Merged
@ma2bd
Copy link
Contributor

ma2bd commented Oct 28, 2024

In general, serde-reflection focuses on binary formats and can't support all of serde but since there's a PR, happy to review it!

@ma2bd ma2bd closed this as completed in #53 Dec 17, 2024
@ma2bd
Copy link
Contributor

ma2bd commented Dec 18, 2024

Resolved in serde-reflection v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support enum variants that have aliases dtolnay-contrib/serde-reflection
2 participants
@ma2bd @juntyr