drivers: modem: wncm14a2a: Fix timeout handling for AT@SOCKCONN

Socket-based API sends timeout K_FOREVER(-1) to net_context_connect()
function where previously net_app APIs used an actual timeout value.
Now that we've switched to socket-based APIs, we reveal poor handling
for the timeout value which causes an error in the WNC-M14A2A driver
due to math performed on the -1 value.

Let's be sure to check for valid timeout values prior to performing
math and then make sure it falls within the allowable range of values
for the AT@SOCKCONN command (30 seconds to 360 seconds).

Signed-off-by: Michael Scott <[email protected]>

Author: mike-scott

drivers/modem/wncm14a2a.c

@@ -1581,10 +1581,14 @@ static int offload_connect(struct net_context *context,
 			   void *user_data)
 {
 	int ret, dst_port = -1;
-	s32_t timeout_sec = timeout / MSEC_PER_SEC;
+	s32_t timeout_sec = -1; /* if not changed, this will be min timeout */
 	char buf[sizeof("AT@SOCKCONN=#,###.###.###.###,#####,#####\r")];
 	struct wncm14a2a_socket *sock;
 
+	if (timeout > 0) {
+		timeout_sec = timeout / MSEC_PER_SEC;
+	}
+
 	if (!context || !addr) {
 		return -EINVAL;
 	}
@@ -1628,10 +1632,11 @@ static int offload_connect(struct net_context *context,
 		return -EINVAL;
 	}
 
-	/* minimum timeout in seconds is 30 */
-	if (timeout_sec < 30) {
-		timeout_sec = 30;
-	}
+	/*
+	 * AT@SOCKCONN timeout param has minimum value of 30 seconds and
+	 * maximum value of 360 seconds, otherwise an error is generated
+	 */
+	timeout_sec = MIN(360, MAX(timeout_sec, 30));
 
 	snprintk(buf, sizeof(buf), "AT@SOCKCONN=%d,\"%s\",%d,%d",
 		 sock->socket_id, wncm14a2a_sprint_ip_addr(addr),