misc: Add k_panic on assert

Replaced forever loop in assert with call to a function.
In post_assert_action() function, k_panic is called.

Forever loop was preventing logs to be printed and had behavior
ependent on the context (low prioriy thread - system continue to
ork, irq - system is blocked).

Signed-off-by: Krzysztof Chruscinski <[email protected]>

Author: nordic-krch

include/misc/__assert.h

@@ -81,16 +81,7 @@
 
 #if __ASSERT_ON
 #include <misc/printk.h>
-
-#if defined(CONFIG_ARCH_POSIX)
-extern void posix_exit(int exit_code);
-#define __ASSERT_POST posix_exit(1)
-#else
-#define __ASSERT_POST             \
-	for (;;) {                \
-		/* spin thread */ \
-	}
-#endif
+void assert_post_action(void);
 
 #define __ASSERT_LOC(test)                               \
 	printk("ASSERTION FAIL [%s] @ %s:%d\n",    \
@@ -102,16 +93,16 @@ extern void posix_exit(int exit_code);
 	do {                                                             \
 		if (!(test)) {                                           \
 			__ASSERT_LOC(test);                              \
-			__ASSERT_POST;                                   \
+			assert_post_action();                            \
 		}                                                        \
 	} while (false)
 
 #define __ASSERT(test, fmt, ...)                                         \
 	do {                                                             \
 		if (!(test)) {                                           \
 			__ASSERT_LOC(test);                              \
-			printk("\t" fmt "\n", ##__VA_ARGS__);      \
-			__ASSERT_POST;                                   \
+			printk("\t" fmt "\n", ##__VA_ARGS__);            \
+			assert_post_action();                            \
 		}                                                        \
 	} while (false)
 

lib/os/CMakeLists.txt

@@ -17,3 +17,5 @@ zephyr_sources_ifdef(CONFIG_JSON_LIBRARY json.c)
 zephyr_sources_if_kconfig(printk.c)
 
 zephyr_sources_if_kconfig(ring_buffer.c)
+
+zephyr_sources_ifdef(CONFIG_ASSERT assert.c)

lib/os/assert.c

@@ -0,0 +1,18 @@
+/*
+ * Copyright (c) 2019 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#include <misc/__assert.h>
+#include <zephyr.h>
+
+void assert_post_action(void)
+{
+	if (IS_ENABLED(CONFIG_ARCH_POSIX)) {
+		extern void posix_exit(int exit_code);
+		posix_exit(1);
+	} else {
+		k_panic();
+	}
+}