Skip to content

[Coverity CID :188744]Memory - corruptions in /drivers/sensor/lis2dh/lis2dh_trigger.c #10581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mandarcthorat1 opened this issue Oct 15, 2018 · 7 comments
Closed

[Coverity CID :188744]Memory - corruptions in /drivers/sensor/lis2dh/lis2dh_trigger.c #10581

mandarcthorat1 opened this issue Oct 15, 2018 · 7 comments
Assignees
@avisconti
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/sensor/lis2dh/lis2dh_trigger.c
Category: Memory - corruptions
Function: lis2dh_thread_cb
Component: Drivers
CID: 188744
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996
@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Oct 15, 2018
@nashif nashif added the priority: medium Medium impact/importance bug label Oct 18, 2018
@galak
Copy link
Collaborator

galak commented Mar 7, 2019

@avisconti ping.

@avisconti
Copy link
Collaborator

I think it is solved by 802ad61.
I probably forgot to mention it, but it seems exactly same issue as #10571 and #10593.

@galak galak closed this as completed Mar 8, 2019
@mandarcthorat1
Copy link
Contributor Author

@avisconti The issue has been again detected by latest coverity scan. Please take a look again.

@avisconti
Copy link
Collaborator

@avisconti The issue has been again detected by latest coverity scan. Please take a look again.

What is the CID for the new scan?

@mandarcthorat1
Copy link
Contributor Author

It has been detected with same CID as before, i.e., 188744.

@avisconti
Copy link
Collaborator

avisconti commented Mar 25, 2019 •
edited
Loading

@mandarcthorat1
I'm not expert on Coverity, but it seems to me that this is maybe a false positive, I don't think there will be
any memory corruption. Since atomic_test_and_clear_bit() is used in other part of the code as well is it possible to see whether the same issue has been issued already and in thata case how it has been closed? Thanks.

@galak
Copy link
Collaborator

galak commented Mar 26, 2019

Closing and update coverity as false positive.

@galak galak closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avisconti avisconti

Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@avisconti @nashif @galak @mandarcthorat1