Skip to content

i2s driver for stm still uses old logger #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nashif opened this issue Oct 15, 2018 · 6 comments
Closed

i2s driver for stm still uses old logger #10610

nashif opened this issue Oct 15, 2018 · 6 comments
Labels
area: Logging bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@nashif
Copy link
Member

nashif commented Oct 15, 2018

@avisconti

commit 7b82e9f
Author: Armando Visconti [email protected]
Date: Thu Jun 14 09:27:46 2018 +0200

drivers: i2s: Add support for I2S stm32

Please move this driver to new logger
@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Logging labels Oct 15, 2018
@avisconti
Copy link
Collaborator

Sure. I'll do it tomorrow.

@avisconti
Copy link
Collaborator

@nashif
How to test it? Porting new logging method was easy enough for doing it right now. But tomorrow I would like to see if I can really see the logs.

@nashif
Copy link
Member Author

nashif commented Oct 16, 2018

sounds good. You test by enabling the new logger :)

@avisconti
Copy link
Collaborator

OK, it works. Nevertheless there are too many logs and I didn't get how to filter them. For example I may want just to see logs from my I2S driver, while now I get logs also from dma driver. Not sure if it is possible to filter the driver from menuconfig.

@avisconti
Copy link
Collaborator

avisconti commented Oct 16, 2018 •
edited
Loading

@nashif
What happens is that if I enable the logs the i2s_read() fails because too many logs means too much delay. Is it possible to enable logs selectively on drivers?

@avisconti avisconti mentioned this issue Oct 16, 2018
Merged
@avisconti
Copy link
Collaborator

@nashif
You may close this issue

@nashif nashif closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Logging bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avisconti @nashif