Skip to content

[Coverity CID :189515]Incorrect expression in /drivers/usb/device/usb_dc_stm32.c #11091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mandarcthorat1 opened this issue Nov 5, 2018 · 4 comments
Assignees
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@mandarcthorat1
Copy link
Contributor

Static code scan issues seen in File: /drivers/usb/device/usb_dc_stm32.c
Category: Incorrect expression
Function: usb_dc_stm32_get_maximum_speed
Component: Drivers
CID: 189515
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

@mandarcthorat1 mandarcthorat1 added area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Nov 5, 2018
@aurel32
Copy link
Collaborator

aurel32 commented Nov 5, 2018

The Coverity analysis consider the data (here the maximum-speed) value to be a constant. In practice it is not the case, different SoC have different values.

So it looks like a false positive to me.

@ydamigos
Copy link
Collaborator

@galak How can I access Coverity's report? Should I request "Organization access" permission?

@galak
Copy link
Collaborator

galak commented Nov 21, 2018

@galak How can I access Coverity's report? Should I request "Organization access" permission?

yes, you need to request access.

@galak galak added the priority: medium Medium impact/importance bug label Nov 21, 2018
@galak
Copy link
Collaborator

galak commented Nov 21, 2018

Agree with @aurel32 assessment, this is intentional because of Device Tree.

@galak galak closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants