[Coverity CID :189509]Integer handling issues in /drivers/sensor/ms5837/ms5837.c

[mandarcthorat1]

Static code scan issues seen in File: /drivers/sensor/ms5837/ms5837.c
Category: Integer handling issues
Function: ms5837_compensate
Component: Drivers
CID: 189509
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

[vanwinkeljan]

requested access to zephyr coverity project for further investigation

[vanwinkeljan]

Coverity reported possible overflow at line 74 in ms5837.c:

	temp_sq = (data->temperature - 2000) * (data->temperature - 2000);

But as per MS5837 datasheet the maximum value of data->temperature is 8500 and the minimum value is -4000 as such no overflow can occur.

[vanwinkeljan]

@agross-linaro, @ceolin could your mark the coverity issue as intentional?

[ceolin]

@vanwinkeljan done, thanks !