Skip to content

net: Zephyr drops TCPv4 packet with extended MAC frame size #13050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmstoi opened this issue Feb 5, 2019 · 3 comments
Closed

net: Zephyr drops TCPv4 packet with extended MAC frame size #13050

rmstoi opened this issue Feb 5, 2019 · 3 comments
Assignees
Labels
area: Conformance Conformance tests area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@rmstoi
Copy link
Collaborator

rmstoi commented Feb 5, 2019

If Zephyr receives a packet with IPv4 TCP datagram occupying only portion of the MAC frame it drops the packet without responding to it.

This regression seems to occur after commit 05f41

Incorrectly working pcap (at master):
ext-frame-tcp-zephyr-master.pcap.gz

Correctly working pcap (at commit 05f41)
ext-frame-tcp-zephyr-05f41.pcap.gz

@rmstoi rmstoi added bug The issue is a bug, or the PR is fixing a bug area: Networking area: Conformance Conformance tests labels Feb 5, 2019
@tbursztyka
Copy link
Collaborator

Let me precise what is happening:

Zephyr is not dropping IPv4 TCP datagram occupying only portion of the MAC frame. And commit 05f41 did not introduce that bug. Instead, by fixing issue #12982 it exposed that current issue.

Issue being again a net_context memory corruption due to uncontrolled concurrent access. Commit 93e5181 tried to fix it (and did it successfully on some path) but it seems that troubles are still lurking around.

Anyway, end result is that zephyr gets in a corrupted state.

@galak galak added the priority: medium Medium impact/importance bug label Feb 9, 2019
@pfalcon
Copy link
Collaborator

pfalcon commented Feb 27, 2019

What's the status of this?

@tbursztyka
Copy link
Collaborator

That was fixed by 45df09c
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Conformance Conformance tests area: Networking bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants