Skip to content

ATMEL SAM family UART and USART - functions u(s)art_sam_irq_is_pending doesn't respect IRQ settings #13624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kubiaj opened this issue Feb 21, 2019 · 2 comments
Closed

ATMEL SAM family UART and USART - functions u(s)art_sam_irq_is_pending doesn't respect IRQ settings #13624

kubiaj opened this issue Feb 21, 2019 · 2 comments
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@kubiaj
Copy link
Contributor

kubiaj commented Feb 21, 2019

The function usart_sam_irq_is_pending (uart_sam_irq_is_pending) return only the masked value of US_CSR register but it doesn't respect if the IRQ is enabled or not. For proper function it must check if the IRQ is enabled for the event.

Expected behavior: Return 0 when values in US_CSR are set and IRQs are disabled.

Impact: Some drivers are not working because they are trying to clear the pending IRQs.

Environment :

  • OS: Linux
  • Toolchain: Zephyr SDK
  • Commit SHA: 06d0b6a

PR in progress.
@kubiaj kubiaj added the bug The issue is a bug, or the PR is fixing a bug label Feb 21, 2019
@nashif nashif added the priority: low Low impact/importance bug label Feb 21, 2019
@kubiaj
Copy link
Contributor Author

kubiaj commented Feb 27, 2019 •
edited by galak
Loading

PR: #13636

@galak
Copy link
Collaborator

galak commented Mar 12, 2019

Closing as we merged #13636

@galak galak closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashif @galak @kubiaj