Skip to content

[Coverity CID :195905]Control flow issues in /arch/x86_64/core/x86_64.c #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aasthagr opened this issue Mar 12, 2019 · 1 comment
Closed
Assignees
Labels
area: X86_64 x86-64 Architecture (64-bit) bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@aasthagr
Copy link
Collaborator

Static code scan issues seen in File: /arch/x86_64/core/x86_64.c
Category: Control flow issues
Function: _cpu_start
Component: Architectures
CID: 195905
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

@galak galak added Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Mar 12, 2019
@galak galak added area: X86 x86 Architecture (32-bit) area: X86_64 x86-64 Architecture (64-bit) bug The issue is a bug, or the PR is fixing a bug and removed area: X86 x86 Architecture (32-bit) bug The issue is a bug, or the PR is fixing a bug labels Mar 12, 2019
@andyross
Copy link
Collaborator

Similar to #14394, it's a false positive. It doesn't like

if (cpu == 0) {
...
} else if (cpu < CONFIG_MP_NUM_CPUS) {

When CONFIG_MP_NUM_CPUS is 1, as is the default in master right now. But it's a configurable, and it's not always 1, just happens to be in whatever configuration was passed to coverity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: X86_64 x86-64 Architecture (64-bit) bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants