Skip to content

Shell doesn't always process input data when it arrives #15260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimparis opened this issue Apr 8, 2019 · 1 comment
Closed

Shell doesn't always process input data when it arrives #15260

jimparis opened this issue Apr 8, 2019 · 1 comment
Assignees
Labels
area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@jimparis
Copy link
Collaborator

jimparis commented Apr 8, 2019

The shell doesn't always consume all input data when it arrives.
For example, when several lines worth of data are pasted simultaneously from the host, the shell will act as if it only received the first or second line. If the host sends even more input, then the shell starts to "catch up" and processes the third original pasted line as if it had just arrived.

Tested on nrf52 with shell over UART but this would affect any transport.

The exact behavior is messy depending on timing and whether the shell_uart RX buffer overflows -- basically the user visible effect is that the shell seems to drop input, then processes old input when new input comes in, etc.

This is fixed by PR #15224

@jimparis jimparis added the bug The issue is a bug, or the PR is fixing a bug label Apr 8, 2019
@carlescufi carlescufi added priority: medium Medium impact/importance bug area: Shell Shell subsystem labels Apr 8, 2019
@jakub-uC
Copy link
Collaborator

jakub-uC commented Apr 8, 2019

I've added @jimparis as a resolver because he already fixed it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants