Skip to content

LwM2M: Fix BT device pending / retry errors #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mike-scott opened this issue Nov 10, 2017 · 9 comments
Closed

LwM2M: Fix BT device pending / retry errors #4888

mike-scott opened this issue Nov 10, 2017 · 9 comments
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@mike-scott
Copy link
Contributor

mike-scott commented Nov 10, 2017

In the bluetooth L2 layer the packets are being compressed prior to send. This means we cannot merely resend the existing packets upon a packet timeout in the LwM2M / CoAP libraries. Much like they do in the TCP subsystem, we need to make a clone of the original data for the pending / retry process.

As a result, we are seeing a double unref on NON-bluetooth devices:
#4391

And on bluetooth devices the retry process fails w/ ENOMEM (-12).

@mike-scott mike-scott self-assigned this Nov 10, 2017
@mike-scott mike-scott added this to the v1.10.0 milestone Nov 10, 2017
@Vudentz
Copy link
Collaborator

Vudentz commented Nov 13, 2017

Not following, is this suggesting to clone every single packet? Perhaps LwM2M should follow the TCP design and have its own poll to clone the packets for timeout handling.

@Vudentz
Copy link
Collaborator

Vudentz commented Nov 13, 2017

Btw, this is not unique to Bluetooth, afaik any driver using 6lo compression will change the packet.

@nashif nashif added the bug The issue is a bug, or the PR is fixing a bug label Nov 14, 2017
@linkmeyer linkmeyer added the priority: medium Medium impact/importance bug label Nov 20, 2017
@galak
Copy link
Collaborator

galak commented Nov 28, 2017

Any updates on a fix for this?

@mike-scott
Copy link
Contributor Author

Let's mark this as 1.11. I want to get the fix right for this.

@galak galak modified the milestones: v1.10.0, v1.11.0 Nov 28, 2017
@carlescufi
Copy link
Member

@mike-scott can we still expect a fix for this on 1.11?

@mike-scott
Copy link
Contributor Author

@carlescufi I think I'll defer this until post net-buf changes land. This fix needs to go into the CoAP lib processing for retry so that it not only fixes LwM2M but also users of CoAP APIs as well. Removing 1.11 target.

@mike-scott mike-scott removed this from the v1.11.0 milestone Jan 24, 2018
@carlescufi carlescufi added this to the v1.12.0 milestone Mar 6, 2018
@nashif
Copy link
Member

nashif commented May 11, 2018

what is the status of this one?

@nashif nashif added priority: low Low impact/importance bug and removed priority: medium Medium impact/importance bug labels May 11, 2018
@mike-scott mike-scott modified the milestones: v1.12.0, v1.13.0 May 31, 2018
@nashif nashif removed this from the v1.13.0 milestone Sep 10, 2018
@nashif
Copy link
Member

nashif commented Nov 5, 2018

@mike-scott ping

@mike-scott
Copy link
Contributor Author

@nashif This issue goes away in the move to sockets. We can close. Unless you want to track it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

6 participants