Skip to content

Name internal functions with less generic names #91433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joolzg opened this issue Jun 11, 2025 · 4 comments
Open

Name internal functions with less generic names #91433

joolzg opened this issue Jun 11, 2025 · 4 comments
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@joolzg
Copy link

joolzg commented Jun 11, 2025

Summary

Just spent ages trying to track down a crash in zephyr master.

Finally found the culprit and it was the idle task being overwritten by a variable i created.

Renaming my variable to idle_data and voila the system is working again.

I got no link errors or warnings.

Describe the solution you'd like

Name all internal tasks/stacks to something a bit more precise for example idle becomes idle_task

Alternatives

No response

Additional Context

No response

@joolzg joolzg added the Enhancement Changes/Updates/Additions to existing features label Jun 11, 2025
Copy link

Hi @joolzg! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

@pdgendt
Copy link
Collaborator

pdgendt commented Jun 11, 2025

Can you provide a bit more details about which variable appears to be global?

@joolzg
Copy link
Author

joolzg commented Jun 11, 2025

idle.c and the idle task.

I added a variable "uint8_t idle[256]" in my code and this is what caused the program to crash.

As i said no warnings when building.

@pdgendt
Copy link
Collaborator

pdgendt commented Jun 13, 2025

CC @nashif @carlescufi
Anything we should do here wrt public vs private naming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

2 participants