-
Notifications
You must be signed in to change notification settings - Fork 114
Remove/adjust 2 Mozilla P-521 lints #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you @clintwilson! I suppose that the logic currently is...
...when it should be a bit more nuanced and
Do you believe that this would be a more accurate lint? |
To revisit this issue @christopher-henderson, it looks like Mozilla has updated the Root Store policy to just allow for P-521
SignatureAlgorithm
So I opened a PR updating these two lints. |
Uh oh!
There was an error while loading. Please reload this page.
e_mp_ecdsa_pub_key_encoding_correct and e_mp_ecdsa_signature_encoding_correct are (I believe) written based on the Mozilla Root Program Policy prohibiting P-521 keys, but this policy does not actually currently prohibit P-521 per Section 5.1:
Unfortunately this does somewhat conflict with the statement preceding this:
However, based on discussions with Mozilla and their Issue 281 it seems absolutely clear that the intent is not to restrict certificates using P-521 curve from existing. Thus, I believe the above referenced lints can be removed -- however if they're doing more than checking for compliance with this section of the Mozilla policy, then they may instead warrant adjustment rather than removal.
Related Issues: #354 #355 #358
The text was updated successfully, but these errors were encountered: