Skip to content

Commit 1af5bdb

Browse files
committed
ios build: Turn on "Missing Localizability" for project.
Part of the RN v0.61 -> v0.62 changes to the template app [1], corresponding to facebook/react-native@ebb629d05. This is a warning we've seen for a while (#4112), and there's no suggestion that we can't do it before the main upgrade commit. This change appears in the Upgrade Support repo's official guide for how to change the Xcode files using Xcode [2]. While some of that guide is out-of-date with the actual Xcode files in the template app, this particular change is correct. [1] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2 [2] react-native-community/upgrade-support#13
1 parent 9afb27e commit 1af5bdb

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

ios/ZulipMobile.xcodeproj/project.pbxproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
83CBB9F71A601CBA00E9B192 /* Project object */ = {
176176
isa = PBXProject;
177177
attributes = {
178-
LastUpgradeCheck = 940;
178+
LastUpgradeCheck = 1160;
179179
TargetAttributes = {
180180
13B07F861A680F5B00A75B9A = {
181181
DevelopmentTeam = 66KHCWMEYB;
@@ -447,6 +447,7 @@
447447
isa = XCBuildConfiguration;
448448
buildSettings = {
449449
ALWAYS_SEARCH_USER_PATHS = NO;
450+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
450451
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
451452
CLANG_CXX_LIBRARY = "libc++";
452453
CLANG_ENABLE_MODULES = YES;
@@ -502,6 +503,7 @@
502503
isa = XCBuildConfiguration;
503504
buildSettings = {
504505
ALWAYS_SEARCH_USER_PATHS = NO;
506+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
505507
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
506508
CLANG_CXX_LIBRARY = "libc++";
507509
CLANG_ENABLE_MODULES = YES;

ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0940"
3+
LastUpgradeVersion = "1160"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0940"
3+
LastUpgradeVersion = "1160"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

0 commit comments

Comments
 (0)