fix: Correctly handle recursive filtering #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that this was a problem when testing a GTK app with the actual AT-SPI adapter. Attempting to unregister the interfaces for a removed node resulted in a D-Bus error saying that the Accessible interface hadn't been registered in the first place. The problem was that the node wasn't registered in the first place, since its parent had the
hidden
flag set, meaning that the parent's filter result wasExcludeSubtree
. But when the node was removed, its filter result wasInclude
, since callingfilter
on the node didn't check the parent, and the node itself didn't have thehidden
flag set.So now,
common_filter
checks the parent.I added
add_subtree
andremove_subtree
because a callback tonode_updated
on a single node can indicate a change in the visibility of the whole subtree. And I added theadded_nodes
andremoved_nodes
sets to ensure that no matter what sequence of events happens, we don't try to register or unregister a node twice in a single set of changes.