Skip to content

Adding sourcemaps to vue dev builds #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021

Conversation

iloveitaly
Copy link
Contributor

Super helpful for in-browser debugging.

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #281 (199c0ae) into master (165ec2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   15.91%   15.91%           
=======================================
  Files          22       22           
  Lines        1062     1062           
  Branches      110      110           
=======================================
  Hits          169      169           
  Misses        848      848           
  Partials       45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165ec2f...199c0ae. Read the comment docs.

@ErikBjare
Copy link
Member

ErikBjare commented May 4, 2021

I'm a bit surprised that sourcemaps aren't generated by default for you. I do remember having issues with sourcemaps in the past, but can't remember if I've had any recent issues.

I found that there's a productionSourcemap option that is even set to true by default, so it seems like it should definitely be set in development builds: https://cli.vuejs.org/config/#productionsourcemap

I also skimmed vuejs/vue-cli#1806 and there seems to be quite a few common issues both with setting this (relating to performance) and with leaving the defaults, not sure what setting this actually does/improves.

Sourcemaps are indeed supposed to be enabled by default: vuejs/vue-cli#1806 (comment)

@iloveitaly
Copy link
Contributor Author

Interesting, if you run vue-cli-service build without any arguments sourcemaps are generated. However, if you run build with --watch sourcemaps are not generated. I posted this in the issue thread to see if we get any interesting responses.

@@ -17,6 +17,8 @@ module.exports = {
});
},
configureWebpack: {
// sourcemaps are not enabled when `--watch` is used https://github.com/vuejs/vue-cli/issues/1806#issuecomment-832111894
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, was just going to suggest you add this comment :)

@ErikBjare
Copy link
Member

Merging!

@ErikBjare ErikBjare merged commit 97e45c4 into ActivityWatch:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants