Skip to content

#3555 Content Sync: prevent timeout errors when sync-ing AEM cloud instances with large volumes of data #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YegorKozlov
Copy link
Contributor

addresses #3555

AEM Cloud has the default read timeout of 60 seconds and ContentSync fails when collecting resources on the remote instance for longer than that.

With this PR the resources are collected in a Sling Job and the tool polls for completion every 3 seconds.

image

Copy link

github-actions bot commented Apr 12, 2025

Test Results

 2 997 files  +18   2 997 suites  +18   1h 37m 47s ⏱️ +19s
 1 913 tests +10   1 913 ✅ +10  0 💤 ±0  0 ❌ ±0 
17 217 runs  +90  17 211 ✅ +90  6 💤 ±0  0 ❌ ±0 

Results for commit c3646ec. ± Comparison against base commit 9112dc0.

This pull request removes 4 and adds 14 tests. Note that renamed tests count towards both.
com.adobe.acs.commons.contentsync.servlet.TestContentCatalogServlet ‑ testContentTreeDoesNotExist
com.adobe.acs.commons.contentsync.servlet.TestContentCatalogServlet ‑ testInvalidStrategyPid
com.adobe.acs.commons.contentsync.servlet.TestContentCatalogServlet ‑ testMissingRequiredParameters
com.adobe.acs.commons.contentsync.servlet.TestContentCatalogServlet ‑ testPageTree
com.adobe.acs.commons.contentsync.TestContentCatalog ‑ testCheckStatus_GivenUp
com.adobe.acs.commons.contentsync.TestContentCatalog ‑ testCheckStatus_InProgress
com.adobe.acs.commons.contentsync.TestContentCatalog ‑ testGetDelta
com.adobe.acs.commons.contentsync.TestContentCatalog ‑ testIsCompleteError
com.adobe.acs.commons.contentsync.TestContentCatalog ‑ testIsComplete_Succeeded
com.adobe.acs.commons.contentsync.TestContentCatalog ‑ testStartCatalogJob
com.adobe.acs.commons.contentsync.TestContentCatalogJobConsumer ‑ testBindUnbindStrategy
com.adobe.acs.commons.contentsync.TestContentCatalogJobConsumer ‑ testGetStrategy_InvalidStrategy
com.adobe.acs.commons.contentsync.TestContentCatalogJobConsumer ‑ testSave
com.adobe.acs.commons.contentsync.servlet.TestContentCatalogServlet ‑ testFailedJobHaveErrorMessage
…

♻️ This comment has been updated with latest results.

@YegorKozlov YegorKozlov changed the title [WIP] #3555 Content Sync: prevent timeout errors when sync-ing AEM cloud instances with large volumes of data #3555 Content Sync: prevent timeout errors when sync-ing AEM cloud instances with large volumes of data Apr 20, 2025
@simontunnat
Copy link

Sounds like a great solution, would really like for this to be reviewed and merged. :)

@davidjgonzalez davidjgonzalez merged commit 81d3d57 into Adobe-Consulting-Services:master Apr 28, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants