Skip to content

OPSEXP-3125 hxi_connector: handle repository extension properties in the extension entrypoint #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 29, 2025
Merged

OPSEXP-3125 hxi_connector: handle repository extension properties in the extension entrypoint #13

merged 17 commits into from
Apr 29, 2025
+211 −29

Conversation

gionn
Copy link
Member

@gionn gionn commented Apr 16, 2025 •
edited
Loading

@gionn gionn self-assigned this Apr 16, 2025
@gionn gionn changed the title OPSEXP-3125 feat(hxi-connector): handle repository extension properties in the extension entrypoint OPSEXP-3125 hxi_connector: handle repository extension properties in the extension entrypoint Apr 16, 2025
@gionn gionn requested a review from a team April 16, 2025 13:42
@gionn gionn marked this pull request as ready for review April 16, 2025 13:47
@github-actions GitHub Actions
Copy link

Docs Build 📝

The docs for this PR have been published here:
https://Alfresco.github.io/alfresco-ansible-collection/pr/13

You can compare to the docs for the main branch here:
https://Alfresco.github.io/alfresco-ansible-collection/branch/main

@gionn gionn force-pushed the OPSEXP-3125-hxi-extension-vars branch from 2d6ca45 to c2422a3 Compare April 23, 2025 07:53
@gionn gionn requested review from alxgomz and pmacius April 23, 2025 08:34
alxgomz
alxgomz reviewed Apr 28, 2025
View reviewed changes
roles/hxi_connector/molecule/default/side_effect.yml Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realising that now, but why are we using the side-effect playbook?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's something you did a while ago in the upstream role, looks like to verify that the service get reloaded upon config change.

here I've reused it to actually test both behaviors of the extension entrypoint (when passing all the arguments vs only the required ones)

@gionn gionn requested review from alxgomz and pmacius April 28, 2025 10:52
@gionn gionn force-pushed the OPSEXP-3125-hxi-extension-vars branch from 70d1b8c to 46ce551 Compare April 28, 2025 13:07
@gionn gionn force-pushed the OPSEXP-3125-hxi-extension-vars branch from 9da85e8 to d32ea60 Compare April 28, 2025 16:26
@gionn gionn removed the request for review from alxgomz April 29, 2025 08:44
@gionn gionn requested review from pmacius and alxgomz April 29, 2025 13:34
pmacius
pmacius approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gionn gionn merged commit f1a2560 into main Apr 29, 2025
11 checks passed
@gionn gionn deleted the OPSEXP-3125-hxi-extension-vars branch April 29, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacius pmacius pmacius approved these changes

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees

@gionn gionn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gionn @alxgomz @pmacius