fix(mega): use newest file for same filename #8422
Open
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mega supports duplicate names but alist does not support. In `List()` method, driver will return multiple files with same name. That makes alist to use oldest version file for listing/downloading. So it is necessary to filter old same name files in a folder. After fixes, all CRUD work normally. Refs AlistGo#8344
Walkthrough此PR修复了AList mega driver在处理同名文件时总是返回最旧版本的问题。通过在 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| } | ||
| if _, ok := fn[n.GetName()]; !ok { | ||
| fn[n.GetName()] = &MegaNode{n} | ||
| } else if sameNameObj := fn[n.GetName()]; (&MegaNode{n}).ModTime().After(sameNameObj.ModTime()) { |
There was a problem hiding this comment.
确保在比较两个文件的修改时间时，ModTime()方法返回的时间是准确的，以避免错误地替换文件。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #8344
Mega 支持一个文件夹下有多个同名文件（duplicate names），不同版本以日期区分。
AList mega driver 的
Link()方法会返回多个「同名」文件，但最终 AList 只会响应第一个版本（最旧的）进行列出/下载。这就导致无论你上传了多少遍，读取到的永远是最旧的版本。PR 是对
Link()里的同名文件进行了过滤，只保留最新版本，这样 CRUD 都能保持一致上图，首先是 Mega 官方
修复前（Test in v3.42）
修复后（PR）
