KS NPE, better exception for #306 #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tombentley I don't see what else can be done in this case ... ? |
tombentley
reviewed
Mar 5, 2020
| @@ -104,7 +104,7 @@ public void close() { | |||
|
|
|||
| protected final S serviceForKey(K key) { | |||
| StreamsMetadata smeta = streams.metadataForKey(storeName, key, keySerde.serializer()); | |||
| if (smeta == StreamsMetadata.NOT_AVAILABLE) { | |||
| if (smeta == null || smeta == StreamsMetadata.NOT_AVAILABLE) { | |||
There was a problem hiding this comment.
null really indicates that there is no matching metadata for the given store and key. Maybe that can be a transient condition (to be honest I don't know, but I'm guessing the store might eventually have that key), or it could indicate a non-transient programming error in your streams application (i.e. you're asking for the wrong key, or the wrong store and it will never become non-null). In any case I think it would be useful to have a distinct exception message, since the NOT_AVAILABLE case is definitely expected to be transient.
There was a problem hiding this comment.
FWIW I opened https://issues.apache.org/jira/browse/KAFKA-9663
EricWittmann
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#306