-
Notifications
You must be signed in to change notification settings - Fork 278
References support refinement #3228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EricWittmann
merged 8 commits into
Apicurio:main
from
carlesarnal:references-support-refinement
Mar 28, 2023
Merged
References support refinement #3228
EricWittmann
merged 8 commits into
Apicurio:main
from
carlesarnal:references-support-refinement
Mar 28, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carlesarnal
commented
Mar 23, 2023
•
edited
Loading
edited
- Calculate the content hash taking into account the references. Now, two artifacts with the same content but with different references result in two completely separated artifacts (different contentId and different content hash). This is especially useful for evolution, where a new version of the same artifact might point to a newer version of the referenced one but without changing the actual content.
- Take references into account for compatibility evolution. The avro compatibility library was broken when references were used. Now references are properly used to calculate the compatibility.
- Implement basic json schema evolution support for artifacts with references. Basically, the reference is checked to be resolvable, but no further checks are made (those checks happen at the artifact reference level).
Thank you for creating a pull request! Pinging @jsenko to respond or triage. |
This was
linked to
issues
Mar 23, 2023
a87ccfc
to
d2ba7cc
Compare
4fb6cd2
to
6986143
Compare
6986143
to
6f410ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.