[PAY-3249] Implement pnagD trending strategy #9273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
raymondjacobson
commented
Jul 25, 2024
| wv = parse(v) | ||
| if wv > K: | ||
| wv = w | ||
| k = (K - max(w, wv)).days |
There was a problem hiding this comment.
this is really the only important change!
rickyrombo
approved these changes
Jul 25, 2024
| CASE | ||
| WHEN tp.owner_follower_count < :y | ||
| THEN 0 | ||
| WHEN EXTRACT(DAYS from now() - aip.created_at) > :week |
There was a problem hiding this comment.
Don't these also need to change?
There was a problem hiding this comment.
Nvm think I'm misreading this on mobile
|
looking into test failure |
raymondjacobson
force-pushed
the
rj-pay-3249
branch
from
223ed2a to
576d4fa
Compare
audius-infra
pushed a commit
that referenced
this pull request
Jul 30, 2024
[df1c126] Longer deadline for fixing files (#9297) Steve Perkins [f713455] [PAY-3236][PAY-3242][PAY-3259] Fix play button in tracks table (#9288) Saliou Diallo [bcd8e13] [PAY-3249] Implement pnagD trending strategy (#9273) Raymond Jacobson [f423f36] Pin Rust version to 1.79.0 (#9290) Marcus Pasell [2065768] Resume cleanup mode (#9285) Steve Perkins
schottra
added a commit
that referenced
this pull request
Jul 30, 2024
* origin/main: (69 commits) Update dn models (#9291) [PAY-3260] Use 'Today' for matching release dates (#9292) [PAY-3258] BoxedTextField can error before form submission (#9305) [PAY-3248][PAY-3256][PAY-3234] Fix misc android issues (#9307) Premium extras updates (#9306) Silence request logs for python es client (#9301) [PAY-3263] add playlists & albums release date if null (#9304) Small FilterButton hover style tweak (#9303) [QA-1448] Fix user badge spacing (#9302) [C-4868] BPM validation (#9295) [C-4854] Add Premium Extras label (#9294) [PAY-3261] Update remix settings copy (#9299) Audius Protocol v0.6.158 Longer deadline for fixing files (#9297) [PAY-3236][PAY-3242][PAY-3259] Fix play button in tracks table (#9288) [PAY-3240] Prevent wrong users from seeing /edit pages (#9298) PAY-3233 Disable reset on select field for AM/PM (#9296) [PAY-3249] Implement pnagD trending strategy (#9273) [PAY-3257] Default prices for premium albums/tracks (#9293) Pin Rust version to 1.79.0 (#9290) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review commit by commit pls!
The main change of this PR is very small, just some other dead code cleanup along the way.
kis defined as our coefficient of decay. Our algo isfinalScore = score ^ (1 - k / time_period)this can be seen as decaying the final score from score to 1 based on what %age of the time period (e.g. trending this week) we have covered.
in existing trending
kis defined ask = now - created_atI update the calculation here to be
basically, if release date is in the future, use created_at, and if release date is in the past, use max(created_at, release_date)
here's the diff
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
We will be able to soak this on stage & prod before switching the default strategy over