-
Notifications
You must be signed in to change notification settings - Fork 821
Forms: sentence case field names #43818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
7066baa
to
eefd81d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
PR's with upstream changes: - Sentence case field names Automattic/jetpack#43818 - Sentence case all UI components Automattic/jetpack#43847
4778c1f
to
14849e8
Compare
PR with upstream changes: - Sentence case field names Automattic/jetpack#43818 Releated: - Sentence case all UI components Automattic/jetpack#43847
Reflect changes done in Automattic/jetpack#43818
Reflect changes done in Automattic/jetpack#43818
Our in-house style is to use sentence casing. In the interim this might mean inconsistencies across UIs like the editor, but longer term this will settle and we have to start somewhere.
Internal references:
We've already used sentence casing in new UIs, and now that innner blocks refactor is merged, we can go through the rest of UIs and update texts.
Rest of UI updated in separate PR.
E2E tests updated in separate PR:
Proposed changes:
Before
After
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: