sample to demo passing images to skills #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeidiSteen
reviewed
Nov 12, 2020
| "# Azure Cognitive Search sample \n", | ||
| "## Passing Images as Binary File References\n", | ||
| "\n", | ||
| "Cognitive Search skillsets that need to pass images to custom skills use a binary file reference to serialize the images to pass them to and from skills. This sample demosntrates an example of how skills can be configured to accept an image as an input from the skillset and return images as outputs to the skillset. This example does nothing more than segment an image based on the layout from OCR. The sole purpose of this sample is to demosntrate how you pass images to skills and how skills can return images.\n", |
There was a problem hiding this comment.
Line 10 -- two typos on "demonstrate" in this paragraph
Can explain why the REST API used here? You could put this in the intro or in the prerequisites: "This sample uses Python and the Search REST API (the Azure SDK for Python does not support knowledge store definitions at this time)."
There was a problem hiding this comment.
I'd rather not call that out as we would need to go back and change that when the knowledge store is supported.
| "skillset_name = f'{datasource_container}-ss'\n", | ||
| "skillset_def = {\n", | ||
| " 'name': f'{skillset_name}',\n", | ||
| " 'description': 'Skillset to enrich hotel reviews with aspect based sentiment',\n", |
There was a problem hiding this comment.
line 168 -- Update the description to match the scenario
|
@HeidiSteen Are we ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jennifermarsman can you review the changes? Added a driver notebook for testing and a python skill that accepts and returns images.