-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CI to use public azdev. #8811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CI to use public azdev. #8811
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @jsntcy, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI scripts to use the public azdev commands, streamlining the testing and verification process. Key changes include:
- Replacing legacy azdev commands with public azdev equivalents in verify_modified_index.sh.
- Removing legacy scripts (verify_license.py and update_index.py) that are now superseded by azdev functionality.
- Updating test_static.sh and Travis configuration to incorporate the public azdev workflow.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
scripts/ci/verify_modified_index.sh | Replaces legacy command calls with "az self-test" and "azdev linter" for improved CI verification. |
scripts/ci/verify_license.py | Removed file; license verification is now expected to be handled by azdev verify license. |
scripts/ci/update_index.py | Removed file; index update functionality is assumed to be automated by new processes. |
scripts/ci/test_static.sh | Replaces custom linting and static analysis commands with standardized azdev commands. |
.travis.yml | Updated installation to include azdev as part of the CI dependencies. |
Comments suppressed due to low confidence (7)
scripts/ci/verify_license.py:1
- Verify that license header validation is now fully integrated into the new workflow (e.g., via 'azdev verify license') and update any related documentation.
Entire file removed
scripts/ci/update_index.py:1
- Ensure that the removal of update_index.py is intentional and that index updates are now properly handled by an alternative automated process.
Entire file removed
scripts/ci/verify_modified_index.sh:34
- Ensure that 'az self-test' provides equivalent verification coverage as the removed 'azdev verify load-all' command.
az self-test
scripts/ci/verify_modified_index.sh:36
- Confirm that 'azdev linter' enforces the same linting rules previously handled by 'azdev cli-lint --ci --extensions' to maintain consistency in code quality checks.
azdev linter $ext
scripts/ci/test_static.sh:4
- Confirm that setting AZDEV_CLI_REPO_PATH to 'NONE' correctly disables CLI repo path processing as intended in the new azdev setup flow.
export AZDEV_CLI_REPO_PATH='_NONE_'
scripts/ci/test_static.sh:7
- Verify that the azdev setup command works as expected with AZDEV_CLI_REPO_PATH set to 'NONE' and does not cause unintended side effects.
azdev setup -r $AZDEV_CLI_REPO_PATH
.travis.yml:7
- Ensure that installing azdev without a fixed version meets your CI requirements and does not introduce unexpected behavior due to version changes.
- pip install pylint==1.9.2 flake8==3.5.0 requests wheel==0.30.0 azdev -q
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.