Skip to content

[Containerapp]: az containerapp arc: Enable setup custom core dns for Openshift #8858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

anandgmenon
Copy link

@anandgmenon anandgmenon commented Jun 12, 2025

… Openshift on Arc


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 04:12
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @anandgmenon,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom CoreDNS setup for OpenShift clusters alongside the existing AKS support.

  • Adds OpenShift-specific constants and logic to create and patch CoreDNS resources.
  • Introduces new functions in _arc_utils.py for managing deployments, config maps, and DNS operator configurations on OpenShift.
  • Updates CLI parameter definitions to include OpenShift as a supported distro.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/containerapp/azext_containerapp/custom.py Adds OpenShift branch in setup_core_dns and related logging/error handling.
src/containerapp/azext_containerapp/_params.py Updates CLI argument to include OpenShift distro with a minor typo in the help text.
src/containerapp/azext_containerapp/_constants.py Introduces new constants for OpenShift support.
src/containerapp/azext_containerapp/_arc_utils.py Adds multiple helper functions for creating/updating resources and patching DNS operator for OpenShift.
Comments suppressed due to low confidence (1)

src/containerapp/azext_containerapp/_arc_utils.py:637

  • [nitpick] The error message appears counterintuitive; consider rephrasing it to indicate that the required key is missing (e.g., "'k4apps-default.io.server' key not found in the coredns-custom ConfigMap in kube-system namespace.").
raise ValidationError("'k4apps-default.io.server' key found in the coredns-custom ConfigMap in kube-system namespace.")

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @anandgmenon

Release Suggestions

Module: containerapp

  • Please log updates into to src/containerapp/HISTORY.rst
  • Update VERSION to 1.2.0b2 in src/containerapp/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants