[MCC] New Version Commands For Microsoft Connected Cache #8863

dcwell · 2025-06-14T01:19:01Z

…ache.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

[] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[] My extension version conforms to the Extension version schema

For new extensions:

[] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…ache.

azure-client-tools-bot-prd · 2025-06-14T01:19:07Z

❌Azure CLI Extensions Breaking Change Test

❌mcc

rule cmd_name rule_message suggest_message

❌ 1002 - CmdRemove mcc ent node get-provisioning-details cmd mcc ent node get-provisioning-details removed please confirm cmd mcc ent node get-provisioning-details removed

⚠️ 1001 - CmdAdd mcc ent node get-deployment-details cmd mcc ent node get-deployment-details added

azure-client-tools-bot-prd · 2025-06-14T01:19:10Z

Hi @dcwell,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

github-actions · 2025-06-14T01:19:14Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

yonzhan · 2025-06-14T01:19:15Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2025-06-14T01:20:19Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copilot

Pull Request Overview

This PR updates the MCC extension commands to use the new 2024-11-30-preview API version and adds several new properties and arguments related to provisioning and cache node configuration.

Bumped all api-version references to 2024-11-30-preview
Added new schema fields (drive_configuration, proxy_url_configuration, tlsCertificateProvisioningKey, creationMethod, currentTlsCertificate, etc.) and removed deprecated ones (proxy_url, update_cycle_type)
Introduced a new --creation-method argument and cleaned up related arg groups

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

File	Description
src/mcc/azext_mcc/aaz/latest/mcc/isp/node/_get_provisioning_details.py	Version bump and new provisioning schema fields (drive_configuration, proxy_url_configuration, TLS).
src/mcc/azext_mcc/aaz/latest/mcc/ent/resource/_list.py	Version bump, swapped list-by-subscription vs list-by-resource-group logic, fixed class names.
src/mcc/azext_mcc/aaz/latest/mcc/ent/node/_update.py	Added `creation_method` argument in multiple commands; removed old flags; updated content mappings.

Comments suppressed due to low confidence (3)

src/mcc/azext_mcc/aaz/latest/mcc/isp/node/_get_provisioning_details.py:196

You've added drive_configuration, proxy_url_configuration, and tlsCertificateProvisioningKey fields to the provisioning schema—consider adding or updating unit tests to cover serialization and deserialization of these new properties.

properties.drive_configuration = AAZListType(

src/mcc/azext_mcc/aaz/latest/mcc/ent/resource/_list.py:51

The original logic distinguished between listing by resource group vs subscription, but here the conditions are inverted and the method calls swapped. Please restore the original intent: use has_value(resource_group) to call the ResourceGroup operation and otherwise call the Subscription operation.

condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True

src/mcc/azext_mcc/aaz/latest/mcc/ent/node/_update.py:76

[nitpick] The creation_method argument is duplicated across multiple commands (create, update). Consider extracting it into a shared helper or base argument schema to reduce duplication and improve maintainability.

_args_schema.creation_method = AAZIntArg(

Copilot · 2025-06-14T01:20:33Z

src/mcc/azext_mcc/aaz/latest/mcc/ent/resource/_list.py

@@ -70,7 +69,7 @@ def _output(self, *args, **kwargs):
        next_link = self.deserialize_output(self.ctx.vars.instance.next_link)
        return result, next_link

-    class EnterpriseMccCustomersListByResourceGroup(AAZHttpOperation):
+    class EnterpriseMccCustomersListBySubscription(AAZHttpOperation):


The class names for the HTTP handlers were swapped. The URL /providers/Microsoft.ConnectedCache/enterpriseMccCustomers should be implemented by the Subscription class, and the resource-group path by the ResourceGroup class. Please rename them to match their actual endpoints.

Suggested change

class EnterpriseMccCustomersListBySubscription(AAZHttpOperation):

class EnterpriseMccCustomersListByResourceGroup(AAZHttpOperation):

github-actions · 2025-06-14T01:22:32Z

For more info about extension versioning, please refer to Extension version schema

necusjz · 2025-06-16T00:00:08Z

/azp run

azure-pipelines · 2025-06-16T00:00:33Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2025-06-16T00:44:30Z

Hi @dcwell

Release Suggestions

Module: mcc

Please log updates into to src/mcc/HISTORY.rst

Update VERSION to 1.0.0b3 in src/mcc/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

@dcwell would you mind update it?

…ed VERSION to 1.0.0b3 in setup.py.

dcwell · 2025-06-16T16:59:26Z

Hi @dcwell

Release Suggestions

Module: mcc

Please log updates into to src/mcc/HISTORY.rst

Update VERSION to 1.0.0b3 in src/mcc/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

@dcwell would you mind update it?

@necusjz I have updated with the suggested changes.

necusjz · 2025-06-17T00:52:25Z

/azp run

azure-pipelines · 2025-06-17T00:52:37Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2025-06-17T07:05:22Z

@dcwell could you plz provide the link of your pull request in Azure/aaz?

…nsions#8863

dcwell · 2025-06-24T21:58:37Z

@necusjz @kairu-ms Please re-review this PR. I have added more changes based on changing requirements for our product. Latest iteration is final.

Here is the AAZ repo PR associated with this:
Azure/aaz#792

necusjz · 2025-06-24T23:41:34Z

/azp run

azure-pipelines · 2025-06-24T23:41:46Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2025-06-25T01:04:35Z

/azp run

azure-pipelines · 2025-06-25T01:04:49Z

Azure Pipelines successfully started running 2 pipeline(s).

dcwell · 2025-06-25T03:16:19Z

/azp run

azure-pipelines · 2025-06-25T03:16:25Z

Commenter does not have sufficient privileges for PR 8863 in repo Azure/azure-cli-extensions

necusjz · 2025-06-25T03:46:02Z

/azp run

azure-pipelines · 2025-06-25T03:46:14Z

Azure Pipelines successfully started running 2 pipeline(s).

[CLI][Extensions][mcc][v1.0.0b3] AAZ PR Pair for Azure/azure-cli-extensions#8863

azclibot · 2025-06-25T04:31:54Z

[Release] Update index.json for extension [ mcc-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128342126&view=results

[CLI][Extensions][MCC] New Version Commands For Microsoft Connected C…

eec61f8

…ache.

Copilot AI review requested due to automatic review settings June 14, 2025 01:19

azure-client-tools-bot-prd bot added this to the July 2025 (2025-07-01) milestone Jun 14, 2025

Copilot AI reviewed Jun 14, 2025

View reviewed changes

yonzhan requested a review from kairu-ms June 14, 2025 09:22

yonzhan assigned kairu-ms Jun 14, 2025

yonzhan requested a review from jsntcy June 14, 2025 09:23

Changes for necusjz comments. Added updates in HISTORY.rst, and updat…

e354ae6

…ed VERSION to 1.0.0b3 in setup.py.

necusjz previously approved these changes Jun 17, 2025

View reviewed changes

Final GA changes for MCC CLI extension

6147171

dcwell dismissed necusjz’s stale review via 6147171 June 24, 2025 21:32

dcwell added a commit to dcwell/aaz that referenced this pull request Jun 24, 2025

[CLI][Extensions][mcc][v1.0.0b3] AAZ PR Pair for Azure/azure-cli-exte…

6fb16d1

…nsions#8863

dcwell mentioned this pull request Jun 24, 2025

[CLI][Extensions][mcc][v1.0.0b3] AAZ PR Pair for https://github.com/Azure/azure-cli-extensions/pull/8863 Azure/aaz#792

Merged

Small bug fix - unregister get-provisioning-details

75520ae

dcwell added 2 commits June 24, 2025 16:50

style check fixes

3c8c0a0

Add examples for lint

5c9a0ae

set creation method registered to false

c9fa621

necusjz approved these changes Jun 25, 2025

View reviewed changes

necusjz added a commit to Azure/aaz that referenced this pull request Jun 25, 2025

Merge pull request #792 from dcwell/main

c31a010

[CLI][Extensions][mcc][v1.0.0b3] AAZ PR Pair for Azure/azure-cli-extensions#8863

necusjz changed the title ~~[CLI][Extensions][MCC] New Version Commands For Microsoft Connected C…~~ [MCC] New Version Commands For Microsoft Connected Cache Jun 25, 2025

necusjz merged commit 21ed215 into Azure:main Jun 25, 2025
24 checks passed

	class EnterpriseMccCustomersListBySubscription(AAZHttpOperation):
	class EnterpriseMccCustomersListByResourceGroup(AAZHttpOperation):

[MCC] New Version Commands For Microsoft Connected Cache #8863

[MCC] New Version Commands For Microsoft Connected Cache #8863

Uh oh!

Conversation

dcwell commented Jun 14, 2025

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

yonzhan commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

CodeGen Tools Feedback Collection

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

necusjz commented Jun 16, 2025

Uh oh!

azure-pipelines bot commented Jun 16, 2025

Uh oh!

necusjz commented Jun 16, 2025

Release Suggestions

Module: mcc

Notes

Uh oh!

dcwell commented Jun 16, 2025

Release Suggestions

Module: mcc

Notes

Uh oh!

necusjz commented Jun 17, 2025

Uh oh!

azure-pipelines bot commented Jun 17, 2025

Uh oh!

necusjz commented Jun 17, 2025

Uh oh!

dcwell commented Jun 24, 2025

Uh oh!

necusjz commented Jun 24, 2025

Uh oh!

azure-pipelines bot commented Jun 24, 2025

Uh oh!

necusjz commented Jun 25, 2025

Uh oh!

azure-pipelines bot commented Jun 25, 2025

Uh oh!

dcwell commented Jun 25, 2025

Uh oh!

azure-pipelines bot commented Jun 25, 2025

Uh oh!

necusjz commented Jun 25, 2025

Uh oh!

azure-pipelines bot commented Jun 25, 2025

Uh oh!

Uh oh!

azclibot commented Jun 25, 2025

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Jun 14, 2025 •

edited

Loading

github-actions bot commented Jun 14, 2025 •

edited

Loading