Skip to content

Subpartitioning: Adds APIs for public release and increase REST API version #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 21, 2023
Merged

Subpartitioning: Adds APIs for public release and increase REST API version #3763

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3a259e4
initial commit, Http version issues still needs to be resolved
NaluTripician Mar 15, 2023
63bf67a
updateContracts + update Http Version
NaluTripician Mar 16, 2023
b31f9f5
updateded version in test
NaluTripician Mar 16, 2023
57dbec5
update contracts
NaluTripician Mar 16, 2023
fbf72db
requested changed
NaluTripician Mar 16, 2023
4af081f
changed name in comments to subpartitioning from multihash
NaluTripician Mar 17, 2023
d5c05c8
undid changes to TestLiteralSerialization.xml
NaluTripician Mar 17, 2023
f765d8a
removed changes to non API.json files
NaluTripician Mar 20, 2023
a0fb0bd
Merge branch 'users/nalutripician/subpartitioningGA' of https://githu…
NaluTripician Mar 20, 2023
94b2b08
removed non XXXAPI.json file changes
NaluTripician Mar 20, 2023
2f75ebc
changed verbage on public comments
NaluTripician Mar 20, 2023
dea3489
changed error message to reflect verbage change
NaluTripician Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public ContainerProperties(string id, string partitionKeyPath)
/// Initializes a new instance of the <see cref="ContainerProperties"/> class for the Azure Cosmos DB service.
/// </summary>
/// <param name="id">The Id of the resource in the Azure Cosmos service.</param>
/// <param name="partitionKeyPaths">The path to the partition key. Example: /location</param>
/// <param name="partitionKeyPaths">The paths of a mulihashed partition key. Example: ["/state", "/city"]</param>
public ContainerProperties(string id, IReadOnlyList<string> partitionKeyPaths)
{
this.Id = id;
Expand Down Expand Up @@ -341,6 +341,11 @@ public string PartitionKeyPath
{
get
{
if (this.PartitionKey?.Kind == PartitionKind.MultiHash && this.PartitionKey?.Paths.Count > 1)
{
throw new NotImplementedException($"This MultiHash collection has more than 1 partition key path please use `PartitionKeyPaths`");
}

return this.PartitionKey?.Paths != null && this.PartitionKey.Paths.Count > 0 ? this.PartitionKey?.Paths[0] : null;
}
set
Expand All @@ -365,7 +370,7 @@ public string PartitionKeyPath
}

/// <summary>
/// JSON path used for containers partitioning
/// List of JSON paths used for containers with subpartitioning
/// </summary>
[JsonIgnore]
public IReadOnlyList<string> PartitionKeyPaths
Expand Down