Modify New-AzVmss Vmss Flex defaulting logic to avoid null reference errors #17610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New-AzVmss when used with a VmssConfig object with OrchestrationMode set (Vmss Flex) hits a null reference error.
This was due to an incorrect usage of the c# syntax 'object?.property?.property2 == null' if check. This caused null to be returned not only when property2 was null, but when property was null. When the code in the if check then referred to property, a null reference occurred.
This update will prevent this issue by adding an explicit if check for object?.property != null before proceeding with the code.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added