-
Notifications
You must be signed in to change notification settings - Fork 4k
Oracle database powershell for new version 2025-03-01 #27895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Oracle Database PowerShell UX definitions to the new API version and adds several new resource command sets, while bumping the module and assembly versions.
- Bumped
apiVersion
from 2023-09-01 to 2025-03-01 across existing location files - Introduced new UX JSON files for GI minor versions, flex components, Exascale and ExaDB clusters, cloud clusters, and autonomous database sub-resources
- Updated
README.md
commit and module-version, and addedAssemblyInfo.cs
with version 1.1.1
Reviewed Changes
Copilot reviewed 99 out of 99 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
locations-giVersions.json |
API version bumped |
locations-giVersions-giMinorVersions.json |
New commands for GI minor versions |
locations-flexComponents.json |
New commands for flexComponents |
locations-dnsPrivateZones.json , locations-dnsPrivateViews.json |
API version bumped |
locations-dbSystemShapes.json |
API version bumped |
locations-autonomousDbVersions.json |
API version bumped |
locations-autonomousDatabaseNationalCharacterSets.json |
API version bumped |
locations-autonomousDatabaseCharacterSets.json |
API version bumped |
exascaleDbStorageVaults.json |
New commands for Exascale storage vaults |
exadbVmClusters.json and exadbVmClusters-dbNodes.json |
New commands for ExaDB VM clusters and DB nodes |
cloudVmClusters.json and cloudVmClusters-dbNodes.json |
API version bumped |
cloudExadataInfrastructures.json and cloudExadataInfrastructures-dbServers.json |
API version bumped |
autonomousDatabases.json and autonomousDatabases-autonomousDatabaseBackups.json |
API version bumped |
README.md |
Updated commit hash & module version |
Properties/AssemblyInfo.cs |
Added new assembly info with version 1.1.1 |
Comments suppressed due to low confidence (2)
src/Oracle/Oracle.Autorest/UX/Oracle.Database/exadbVmClusters-dbNodes.json:9
- Command name uses "ExascaleDbNode" but the resourceType and path refer to ExaDB VM clusters. Rename to "Get-AzOracleExadbDbNode" (and update associated URLs) for consistency.
"name": "Get-AzOracleExascaleDbNode",
src/Oracle/Oracle.Autorest/UX/Oracle.Database/locations-giVersions-giMinorVersions.json:7
- New cmdlet "Get-AzOracleGiMinorVersion" has been added but there are no tests for it. Please add unit or integration tests to cover this command.
"commands": [
src/Oracle/Oracle.Autorest/UX/Oracle.Database/exascaleDbStorageVaults.json
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the examples in the files under the examples folder and test cases for the new cmdlets.
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@mihretkidane-OCI Can you please add the missing examples and test cases? |
@vidai-msft we have added some examples and added test scenario please help review and let us know what's missing. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@mihretkidane-OCI Please fill in the missing examples and test cases as instructed in the CI. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@mihretkidane-OCI Please fix the example and test failure issues detected in the pipeline. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.