[Microsoft.StorageActions][StorageTasks] Address SDK team feedback #28718

golddove · 2024-04-17T10:52:49Z

Fix spec to reflect actual service behavior (identity and properties are required). We are in Public Preview and this is the behavior customers have been experiencing, but the SDK team noticed we missed marking the property required in the swagger. Fixing the discrepancy - there is no new breaking change for customers using the service.

Description/sample updates

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- Fixing spec to reflect actual service behavior (identity, properties are required). We are in Public Preview and this is the behavior customers have been experiencing, but the SDK team noticed we missed marking the property required in the swagger. Fixing the discrepancy - there is no new breaking change for customers using the service.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Update to reflect service behavior Description/sample updates

openapi-pipeline-app · 2024-04-17T10:52:53Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-04-17T10:52:53Z

Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.8)	new version	base version
storageactions.json	2023-01-01(c4d2940)	2023-01-01(main)

Rule	Message
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L519:7 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L519:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L78:13 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L78:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L93:13 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L93:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L99:13 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L99:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L200:13 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L200:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L249:13 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L249:13
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L735:11 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L731:11
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'identity, properties' that was not found in the old version. New: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L517:5 Old: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L517:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2023-01-01	package-2023-01-01(c4d2940)	package-2023-01-01(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L56
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:type. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:enabled. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:description. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:action. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:if. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:condition. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:operations. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L524
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L524
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L555
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L555
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L582
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L582
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L621
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L625
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L644
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L662
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L694
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L735
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L735
⚠️ OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'StorageTaskAssignmentModel'. Consider using the plural form of 'StorageTaskAssignment' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L360
⚠️ UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ListStorageTasksByResourceGroup Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L413
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L483
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L574
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L981

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-17T10:52:54Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed in generating from 8cbc671daa5e025927f2d983151cbcfe1f4b6ec0. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to packe sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact

❌Azure.ResourceManager.Storageactions [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from 8cbc671daa5e025927f2d983151cbcfe1f4b6ec0. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh]
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
cmderr	[automation_init.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-storageactions [Preview SDK Changes]
- azure_mgmt_storageactions-1.0.0b1-py3-none-any.whl
- azure-mgmt-storageactions-1.0.0b1.zip

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 8cbc671daa5e025927f2d983151cbcfe1f4b6ec0. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-storageactions [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-storageactions-1.0.0-beta.2.jar
- azure-resourcemanager-storageactions-1.0.0-beta.2-sources.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 8cbc671daa5e025927f2d983151cbcfe1f4b6ec0. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/storageactions/armstorageactions [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 8cbc671daa5e025927f2d983151cbcfe1f4b6ec0. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-storageactions [Preview SDK Changes]

azure-arm-storageactions-1.0.0.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-17T10:52:54Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/storageactions/armstorageactions	https://apiview.dev/Assemblies/Review/dd00eb4934814e7c8a86d64c4e5545f9?revisionId=7c47bee037874f9ba44fc973042d42e0
Java	azure-resourcemanager-storageactions	https://apiview.dev/Assemblies/Review/411f0a297368439b8f21208a54857184?revisionId=d8eb530af5b74d6c8e2a8ce9c025ee88
JavaScript	@azure/arm-storageactions	https://apiview.dev/Assemblies/Review/cfa9417d62d5407d8afdccd3f6d4bc04?revisionId=737cb982b9d94927bad05ce49eb23aff
Swagger	Microsoft.StorageActions	https://apiview.dev/Assemblies/Review/87fcd068316f442e8eabc48c31c63ba7?revisionId=737e9c6d0a7e49fc880960a744367f23

...orageactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json

openapi-workflow-bot · 2024-04-19T04:52:32Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

...orageactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json

TimLovellSmith · 2024-05-02T05:17:58Z

      "description": "Storage Task Arm Id."

Another description you can reword:

[same feedback about try to avoid referring to ARM - its just an implementation detail from the point of view of anyone reading Azure API docs. ]

Could reword to: "The Azure Storage Task resource ID"
(or is it just 'an ID', not 'the ID'?)

Refers to: specification/storageactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json:908 in 43a9ee3. [](commit_id = 43a9ee3, deletion_comment = False)

TimLovellSmith

Signing off with minor comments you can address before merging

…ions-2023-01-01

…zure#28718) * Address SDK team feedback: Update to reflect service behavior Description/sample updates * Fix required level * Address model validation errors * Prettier * Also fix properties to required to match service behavior * Reword descriptions

Address SDK team feedback:

8c232bc

Update to reflect service behavior Description/sample updates

azure-sdk mentioned this pull request Apr 17, 2024

[AutoPR azure-resourcemanager-storageactions] [Microsoft.StorageActions][StorageTasks] Address SDK team feedback azure-sdk/azure-sdk-for-java#10251

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 17, 2024

azure-sdk mentioned this pull request Apr 17, 2024

[AutoPR Azure.ResourceManager.Storageactions] [Microsoft.StorageActions][StorageTasks] Address SDK team feedback azure-sdk/azure-sdk-for-net#7763

Closed

blueww reviewed Apr 18, 2024

View reviewed changes

...orageactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json Outdated Show resolved Hide resolved

Fix required level

2bef0c2

azure-sdk mentioned this pull request Apr 19, 2024

[AutoPR sdk/resourcemanager/storageactions/armstorageactions] [Microsoft.StorageActions][StorageTasks] Address SDK team feedback azure-sdk/azure-sdk-for-go#9665

Closed

Address model validation errors

87d257b

golddove removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 19, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 19, 2024

Prettier

91e0fb0

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 19, 2024

Also fix properties to required to match service behavior

43a9ee3

AzureRestAPISpecReview added NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels May 1, 2024

golddove added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels May 1, 2024

TimLovellSmith reviewed May 2, 2024

View reviewed changes

...orageactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json Outdated Show resolved Hide resolved

TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 2, 2024

TimLovellSmith approved these changes May 2, 2024

View reviewed changes

TimLovellSmith removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2024

Reword descriptions

bdd7c05

AzureRestAPISpecReview added NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels May 2, 2024

golddove removed the NotReadyForARMReview label May 2, 2024

Merge branch 'main' into golddove-storageactions-Microsoft.StorageAct…

c156dc1

…ions-2023-01-01

golddove added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2024

AzureRestAPISpecReview added NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 2, 2024

golddove added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels May 2, 2024

TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 2, 2024

golddove added MergeRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 2, 2024

blueww mentioned this pull request May 7, 2024

[StorageAction] onboard StorageAction with autorest Azure/azure-powershell#24841

Merged

6 tasks

golddove added 2 commits May 7, 2024 19:06

Merge branch 'main' into golddove-storageactions-Microsoft.StorageAct…

7613dae

…ions-2023-01-01

Merge branch 'main' into golddove-storageactions-Microsoft.StorageAct…

c4d2940

…ions-2023-01-01

madhura-np merged commit 8f19688 into main May 8, 2024
30 of 32 checks passed

madhura-np deleted the golddove-storageactions-Microsoft.StorageActions-2023-01-01 branch May 8, 2024 05:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Microsoft.StorageActions][StorageTasks] Address SDK team feedback #28718

[Microsoft.StorageActions][StorageTasks] Address SDK team feedback #28718

Uh oh!

golddove commented Apr 17, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

openapi-workflow-bot bot commented Apr 19, 2024

Uh oh!

Uh oh!

TimLovellSmith commented May 2, 2024

Uh oh!

TimLovellSmith left a comment

Uh oh!

Uh oh!

Uh oh!

[Microsoft.StorageActions][StorageTasks] Address SDK team feedback #28718

[Microsoft.StorageActions][StorageTasks] Address SDK team feedback #28718

Uh oh!

Conversation

golddove commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app bot commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Uh oh!

openapi-workflow-bot bot commented Apr 19, 2024

Uh oh!

Uh oh!

TimLovellSmith commented May 2, 2024

Uh oh!

TimLovellSmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

golddove commented Apr 17, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 17, 2024 •

edited

Loading