-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Batch Mangement Plane 2025-06-01 #35105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
pl follow the quidance for CMK described here - https://github.com/cloud-and-ai-microsoft/resource-provider-contract/blob/b32b6e22b3a151049fdfd5275eb0c748185a94bc/v1.0/common-api-contracts.md?plain=1#L198 Refers to: specification/batch/resource-manager/Microsoft.Batch/stable/2025-06-01/BatchManagement.json:6543 in 13f5ea6. [](commit_id = 13f5ea6, deletion_comment = False) |
@rkmanda The removal of default value for jobDefaultOrder was due to a LintDiff failure saying that "Properties of a PATCH request body must not have default value, property:jobDefaultOrder |
@wiboris - I didn't see anything addressing this comment: #35105 (comment). Please take a look. |
This link might render better: https://github.com/cloud-and-ai-microsoft/resource-provider-contract/blob/b32b6e22b3a151049fdfd5275eb0c748185a94bc/v1.0/common-api-contracts.md#customer-managed-key-encryption. |
Thanks for your comments, @mentat9 , @rkmanda In my understanding to the infrastructureEncryption , this property should be added when we allow customer to disable infrastructure encryption, and it is preferred to make infrastructure (aka platform) encryption mandatory. So this property is related to how we behave on the platform-level encryption. However, supporting CustomerManagedKey in Batch does not affect the platform-level encryption, and the setting on platform-level encryption did not ever change. Besides, we always use the server-side encryption (https://learn.microsoft.com/en-us/azure/virtual-machines/disk-encryption) to encrypt disks, no matter if CustomerManagedKey or other encryption methods are enabled. So I think we do not need to add this property. |
Thats fair but how about the rest of the property structure? the recommendation is to use the payload structure as defined in the RPC encryption etc. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.