AzureCompute DiskRP 2025-01-02 release #35205

grizzlytheodore · 2025-06-10T17:49:12Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

* Swagger changes for ConfidentialVMv2 * update description of importsecure and uploadpreparedsecure create options

* Adding supportedSecurityOption * Updating description for supportedSecurityOption * Fixing pretty check errors * Formatting file Disk_Create_FromAnAzureComputeGalleryImage.json * Fixing prettier issues --------- Co-authored-by: Varsha Sankar <[email protected]>

…eatures (#34917) * fixing typo elasticSanResourceId * Swagger changes for Instant Access Snapshot and Availability Policy features * missed file in previous commit * adding missed description AvailabilityPolicy * adding missed references * updating descriptions * fixing casing * refactoring * refactoring-2 * fixing model validation * changing camel case of defintion of SnapshotAccessState --------- Co-authored-by: Theodore Chang <[email protected]>

openapi-pipeline-app · 2025-06-10T17:49:16Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-06-10T17:49:17Z

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

github-actions · 2025-06-10T17:51:59Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Swagger	Microsoft.Compute
Go	sdk/resourcemanager/compute/armcompute
Java	com.azure.resourcemanager:azure-resourcemanager-compute-generated
JavaScript	@azure/arm-compute
C#	Azure.ResourceManager.Compute

mentat9 · 2025-06-13T23:43:04Z

...cation/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2025-01-02/diskRPCommon.json

+            "modelAsString": true
+          }
+        },
+        "instantAccessDurationMinutes": {


instantAccessDurationMinutes

Add min/max values as appropriate. #Closed

@PrambMS, could you please add?

added minimu. per @PrambMS , there is no set maximum for the property

minimum added. per @PrambMS , there is no set maximum

mentat9 · 2025-06-13T23:43:05Z

...cation/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2025-01-02/diskRPCommon.json

+          "format": "int64",
+          "description": "“For snapshots created from Premium SSD v2 or Ultra disk, this property determines the time in minutes the snapshot is retained for instant access to enable faster restore."
+        },
+        "securityMetadataUri": {


securityMetadataUri

Add format: uri #Closed

We always use type: string for all these attributes, pls refer similar attributes like sourceUri, securityDataUri .

mentat9 · 2025-06-13T23:43:10Z

...cation/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2025-01-02/diskRPCommon.json

+          "type": "string",
+          "description": "A SAS uri for accessing a VM guest state."
+        },
+        "securityMetadataAccessSAS": {


securityMetadataAccessSAS

Consider adding Uri to the name, e.g. securityMetadataAccessSasUri and format: uri to the type.

Also, if this is a secret, add x-ms-secret extension (and it must be nulled/emptied out in CRUD responses).

@aayushkher please see ARM's comment

This attribute has been decided on the basis of existing attributes, pls refer accessSAS and securityDataAccessSAS.

to stay consistent with it sibling properties, which end in "SAS", we won't rename the property. But I did add x-ms-secret and format uri

This attribute is a user SAS which must be shown to customers to download/upload contents to the given SAS. If the tag "x-ms-secret" automatically redacts the information in the response then this should not added for this attribute.

Removing x-ms-secret because it is needs to be shown in CRUD operations

grizzlytheodore and others added 6 commits May 20, 2025 12:59

add 2025-01-02 folder

1bf3443

update version references

a6e34a2

update readme

f19477a

Swagger changes for ConfidentialVMv2 (#35011)

206f030

* Swagger changes for ConfidentialVMv2 * update description of importsecure and uploadpreparedsecure create options

grizzlytheodore requested review from dkulkarni-ms, haagha and MS-syh2qs as code owners June 10, 2025 17:49

microsoft-github-policy-service bot added the Compute label Jun 10, 2025

github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jun 10, 2025

grizzlytheodore added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jun 11, 2025

mentat9 reviewed Jun 13, 2025

View reviewed changes

mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 13, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 13, 2025

add format: uri

8e7aae4

openapi-pipeline-app bot added PipelineBotTrigger and removed PipelineBotTrigger labels Jun 16, 2025

openapi-pipeline-app bot added PipelineBotTrigger labels Jun 16, 2025

add minimum

04a7af2

openapi-pipeline-app bot added PipelineBotTrigger and removed PipelineBotTrigger labels Jun 16, 2025

add x-ms-secret

cbf60e9

grizzlytheodore added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jun 17, 2025

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 17, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 17, 2025

remove x-ms-secret

7983fc3

grizzlytheodore enabled auto-merge (squash) June 17, 2025 20:55

AzureCompute DiskRP 2025-01-02 release #35205

Are you sure you want to change the base?

AzureCompute DiskRP 2025-01-02 release #35205

Conversation

grizzlytheodore commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

mentat9 Jun 13, 2025 • edited by rkmanda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mentat9 Jun 13, 2025 • edited by rkmanda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mentat9 Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aayushkher Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

grizzlytheodore commented Jun 10, 2025 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2025 •

edited

Loading

openapi-pipeline-app bot commented Jun 10, 2025 •

edited

Loading

github-actions bot commented Jun 10, 2025 •

edited

Loading

mentat9 Jun 13, 2025 •

edited by rkmanda

Loading

mentat9 Jun 13, 2025 •

edited by rkmanda

Loading

mentat9 Jun 13, 2025 •

edited

Loading

aayushkher Jun 17, 2025 •

edited

Loading