Skip to content

DevTestLab : Migrate to TypeSpec API #35234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

nandiniYeltiwar
Copy link

@nandiniYeltiwar nandiniYeltiwar commented Jun 11, 2025

This PR uses the TypeSpec to OpenAPI migration tool to generate typespec code. The PR also contains API updates as they were long overdue. Our last stable release happened 7 years back .

Copy link

openapi-pipeline-app bot commented Jun 11, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Jun 11, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

github-actions bot commented Jun 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.DevTestLab
JavaScript @azure/arm-devtestlabs
Java com.azure.resourcemanager:azure-resourcemanager-devtestlabs

@nandiniYeltiwar nandiniYeltiwar changed the title Migrate to TypeSpec API DevTestLabs : Migrate to TypeSpec API Jun 11, 2025
@nandiniYeltiwar nandiniYeltiwar changed the title DevTestLabs : Migrate to TypeSpec API DevTestLab : Migrate to TypeSpec API Jun 11, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 11, 2025

These settings apply only when `--tag=package-2025-06-preview` is specified on the command line.

``` yaml $(tag) == 'package-2015-05-preview'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it looks like the 'package-2015-05-preview' doesn’t match the tag name package-2025-06-preview mentioned above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for pointing that out! Fixed it.

@nandiniYeltiwar
Copy link
Author

@jianingwang123 I do not have permissions to update the labels for the PR. I would like to add the label PublishToCustomers.

@nandiniYeltiwar nandiniYeltiwar enabled auto-merge (squash) June 16, 2025 16:32
@rkmanda
Copy link
Member

rkmanda commented Jun 16, 2025

  {

Have you worked with the TypeSpec team on how to fix the errors showing up in the swagger lintdiff check already? Also are these violations already shipped in a previous stable version or are these restricted to a preview version? Pl setup 45 min with me to go over the PR..


Refers to: specification/devtestlabs/resource-manager/Microsoft.DevTestLab/preview/2025-06-05-preview/DTL.json:8 in 74ba0e1. [](commit_id = 74ba0e1, deletion_comment = False)

@rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 16, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview Devtestlab new-api-version resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants