-
Notifications
You must be signed in to change notification settings - Fork 5.4k
DevTestLab : Migrate to TypeSpec API #35234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
||
These settings apply only when `--tag=package-2025-06-preview` is specified on the command line. | ||
|
||
``` yaml $(tag) == 'package-2015-05-preview' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it looks like the 'package-2015-05-preview' doesn’t match the tag name package-2025-06-preview
mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks for pointing that out! Fixed it.
@jianingwang123 I do not have permissions to update the labels for the PR. I would like to add the label PublishToCustomers. |
Have you worked with the TypeSpec team on how to fix the errors showing up in the swagger lintdiff check already? Also are these violations already shipped in a previous stable version or are these restricted to a preview version? Pl setup 45 min with me to go over the PR.. Refers to: specification/devtestlabs/resource-manager/Microsoft.DevTestLab/preview/2025-06-05-preview/DTL.json:8 in 74ba0e1. [](commit_id = 74ba0e1, deletion_comment = False) |
This PR uses the TypeSpec to OpenAPI migration tool to generate typespec code. The PR also contains API updates as they were long overdue. Our last stable release happened 7 years back .