[Storage] get_account_info for all clients, set/get_tags for BlobClient
#2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
requested review from
heaths,
RickWinter,
LarryOsterman and
jalauzon-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for retrieving account info (sku_name, account_kind) on all client types and implements set_tags/get_tags on BlobClient, alongside updating tests and regenerating against the latest spec.
- Exposed new tag and account-info models in
src/lib.rsand added client methods (get_account_info,set_tags,get_tags) - Added corresponding integration tests for service, container, and blob clients
- Updated TSP location, assets tag, and test helper utility
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_blob_test/src/lib.rs | Added test_blob_tag_equality helper and import |
| sdk/storage/azure_storage_blob/tsp-location.yaml | Bumped spec commit for regen |
| sdk/storage/azure_storage_blob/tests/blob_service_client.rs | Added test_get_account_info for service client |
| sdk/storage/azure_storage_blob/tests/blob_container_client.rs | Added test_get_account_info for container client |
| sdk/storage/azure_storage_blob/tests/blob_client.rs | Added test_blob_tags and test_get_account_info |
| sdk/storage/azure_storage_blob/src/lib.rs | Re-exported new tag and account-info types |
| sdk/storage/azure_storage_blob/src/clients/blob_service_client.rs | Added get_account_info method |
| sdk/storage/azure_storage_blob/src/clients/blob_container_client.rs | Added get_account_info method |
| sdk/storage/azure_storage_blob/src/clients/blob_client.rs | Added set_tags, get_tags, and get_account_info |
| sdk/storage/assets.json | Updated asset tag hash |
Comments suppressed due to low confidence (1)
sdk/storage/azure_storage_blob/tests/blob_client.rs:303
- The test references
RequestContentbut it is not imported. Adduse azure_core::RequestContent;at the top of this file to resolve the undefined name.
blob_client
.set_tags(RequestContent::try_from(blob_tags.clone())?, None)
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
mainbranch in feature/blob-tspget_account_infoforBlobClient,ContainerClient, andBlobServiceClientset_tagsandget_tagsforBlobClientAccompanying TypeSpec changes (merge before merging this):
Azure/azure-rest-api-specs#35044