globalThis instead of window #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey mate, thanks for writing this. Noticed this one's been sitting here for a while. Would you happen to have your own NPM fork published of it? (I did a quick search, but couldn't find anything resembling your username here on NPM) |
kevin-dp
added a commit
to electric-sql/electric
that referenced
this pull request
Jun 9, 2025
This is a follow up PR on #2546 and #2544. It solves a bug related with 409s (must refetch) in SSE mode and it replaces the EventSource browser API by the [fetch-event-source](https://github.com/Azure/fetch-event-source) library. I refactored the `ShapeStream.#start` method which was becoming very big and complex. To this end, i split the logic into helper methods that handle the different parts that need to happen (building the shape URL, making the request, parsing the response headers, handling the response body, etc.). I had to patch the [fetch-event-source](https://github.com/Azure/fetch-event-source) library because it relies on browser-specific features such as `document` and `window` (cf. Azure/fetch-event-source#41). But we want our client to also work in server-side JS environments. I also had to patch the `fetch-event-source` library because it does not abort the fetch when you pass an already aborted signal. A complete description of the bug and the fix can be found here: Azure/fetch-event-source#98.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make is possible to use this package on a browser extension or NodeJS