-
Notifications
You must be signed in to change notification settings - Fork 77
chore: update sigs.k8s.io/karpenter to v1.4.0 #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 12698619779Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First quick pass completed. Few minor comments. Will take a closer look at a few sections tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only gave it a quicker review, but nothing jumped out and looks good to me.
Do think it's best to get a little longer pass review from someone before completing though for assurance.
Description
Update sigs.k8s.io/karpenter to v1.4.0. Most of the changes in provider are straightforward, here are some less obvious:
How was this change tested?
make presubmit
Does this change impact docs?
Release Note