Skip to content

chore: update sigs.k8s.io/karpenter to v1.4.0 #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Apr 19, 2025

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Dec 3, 2024

Description

Update sigs.k8s.io/karpenter to v1.4.0. Most of the changes in provider are straightforward, here are some less obvious:

  • Remove support for webhooks
  • Remove alternative operator - should no longer be needed
  • Minimal support for Node Repair policies introduced, disabled (behind feature flag), enabled for testing only 9d265f1
  • Have instance Delete call Get first (including to satisfy new sigs.k8s.io/karpenter expectation) e283696
  • Restore "should drain pods on a node in order" E2E test (now supported) f848350
  • "karpenter.azure.com/aksnodeclass" label (used internally) is allowed

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added the area/dependency Issues or PRs related to dependency changes label Dec 3, 2024
@tallaxes tallaxes self-assigned this Dec 3, 2024
@coveralls
Copy link

coveralls commented Dec 4, 2024

Pull Request Test Coverage Report for Build 12698619779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 12 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.453%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 2 12 16.67%
Totals Coverage Status
Change from base Build 12678197330: 0.03%
Covered Lines: 47742
Relevant Lines: 50016

💛 - Coveralls

@tallaxes tallaxes changed the title chore: update sigs.k8s.io/karpenter to v1.1.0 chore: update sigs.k8s.io/karpenter to v1.1.1 Jan 8, 2025
@tallaxes tallaxes marked this pull request as ready for review April 3, 2025 16:43
@tallaxes tallaxes requested review from matthchr and charliedmcb April 3, 2025 21:04
@tallaxes tallaxes changed the title chore: update sigs.k8s.io/karpenter to v1.3.2 chore: update sigs.k8s.io/karpenter to v1.4.0 Apr 17, 2025
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First quick pass completed. Few minor comments. Will take a closer look at a few sections tomorrow.

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only gave it a quicker review, but nothing jumped out and looks good to me.

Do think it's best to get a little longer pass review from someone before completing though for assurance.

@tallaxes tallaxes merged commit c602c65 into main Apr 19, 2025
11 checks passed
@tallaxes tallaxes deleted the tallaxes/karpenter-bump-1.1.0 branch April 19, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants