Move the ADAL automation pipeline from IDDP to Engineering #162

wainaina · 2022-10-27T16:12:30Z

Task: https://dev.azure.com/IdentityDivision/Engineering/_boards/board/t/Auth%20Client%20-%20Android/Backlog%20items/?workitem=1961787

Move the following pipeline from IDDP to Engineering and convert to YML

https://dev.azure.com/IdentityDivision/IDDP/_build?definitionId=1288

Also incorporate sharding and pipeline parameters as done in other pipelines here: AzureAD/microsoft-authentication-library-for-android#1683

Pipeline for review URL: https://identitydivision.visualstudio.com/Engineering/_build?definitionId=1790&_a=summary

p3dr0rv · 2022-10-31T17:43:08Z

azure-pipelines/ui-automation/templates/build-adal-automation-app.yml

@@ -0,0 +1,63 @@
+parameters:


nit: add header. (What is this pipeline doing and what variables it use)

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

somalaya · 2022-10-31T18:12:19Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+              packageDownloadExternal: 'broker-host'
+              versionDownloadExternal: '${{ parameters.oldBrokerHostVersion }}'
+          - task: UniversalPackages@0
+            displayName: 'Download com.microsoft.windowsintune.companyportal-signed'


nit : Download Company Portal apk from feed

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

p3dr0rv · 2022-11-16T16:37:50Z

azure-pipelines/ui-automation/templates/flank/run-on-firebase-with-flank.yml

@@ -22,6 +22,10 @@ parameters:
    type: number
  - name: testRunTitle
    type: string
+  - name: otherFiles


remove, duplicated param (see line 12)

fadidurah · 2022-11-16T18:52:08Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+    branches:
+      include:
+        - dev
+    always: true


Let's not use YML schedules. Instead, you can use the scheduled triggers feature in ADO. This way, we can diasble a broken pipeline without needing a PR to do it. Here's a recent PR i did this in: AzureAD/microsoft-authentication-library-for-android#1721

fadidurah · 2022-11-16T18:56:23Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+    always: true
+
+parameters:
+  - name: firebaseDeviceId


We should use oriole 32 as the default (best automation results)

fadidurah · 2022-11-16T18:57:18Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+  - name: testTargetPackages
+    displayName: Packages as Test Targets
+    type: string
+    default: package com.microsoft.identity.client.broker.automationapp.testpass, notAnnotation org.junit.Ignore


default: package com.microsoft.identity.client.broker.automationapp.testpass, notAnnotation org.junit.Ignore, notAnnotation com.microsoft.identity.client.ui.automation.annotations.DoNotRunOnPipeline

fadidurah · 2022-11-16T18:59:44Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+  # Brokers
+  - stage: 'brokers'
+    dependsOn: []    # this removes the implicit dependency on previous stage and causes this to run in parallel
+    displayName: Brokers and Azure Sample APKs


I already added a template that does this step, you can check if it would fit into this pipeline as well. download-brokers-and-azure-sample.yml.

fadidurah · 2022-11-16T19:00:21Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+    jobs:
+      - template: ./templates/build-broker-automation-app.yml
+        parameters:
+          brokerApp: AutoBroker


AutoBroker? Should this BrokerHost?

fadidurah · 2022-11-16T19:01:00Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+      - template: ./templates/build-broker-automation-app.yml
+        parameters:
+          brokerApp: AutoBroker
+          brokerFlavor: Dist


I think this should be Local

fadidurah · 2022-11-16T19:02:27Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+  oldBrokerHostApk: brokerHost-local-debug.apk
+  firebaseTimeout: 45m
+  brokerApp: brokerautomationapp-dist-AutoBroker-debug.apk
+  brokerTestApp: brokerautomationapp-dist-AutoBroker-debug-androidTest.apk


Should these point to auto broker if this pipeline uses BrokerHost?

If you do intend to use auto broker, you'll need to pull in OldAuthenticator, since Authenticator will be the broker used in the update scenario tests.

fadidurah · 2022-11-16T19:03:41Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+          otherFiles: "/data/local/tmp/CompanyPortal.apk=$(Pipeline.Workspace)/brokerapks/$(companyPortalApk),\
+                                  /data/local/tmp/Authenticator.apk=$(Pipeline.Workspace)/brokerapks/$(authenticatorApk),\
+                                  /data/local/tmp/Authenticator.apk=$(Pipeline.Workspace)/azureSample/$(azureSampleApk),\
+                                  /data/local/tmp/BrokerHost.apk=$(Pipeline.WorkSpace)/brokerHost/$(oldBrokerHostApk)"


Otherfiles look off here. You are push BrokerHost.apk but sourcing it from $(oldBrokerHostApk) and you are not pushing an OldBrokerHost

fadidurah · 2022-11-16T19:04:25Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+      - template: ./templates/flank/run-on-firebase-with-flank.yml
+        parameters:
+          automationAppApkPath: "$(Pipeline.Workspace)/brokerautomationapks/brokerautomationapp-dist-AutoBroker-debug.apk"
+          automationAppTestApkPath: "$(Pipeline.Workspace)/brokerautomationapks/brokerautomationapp-dist-AutoBroker-debug-androidTest.apk"


I think you can use variables brokerApp and brokerTestApp here

fadidurah · 2022-11-16T19:05:42Z

azure-pipelines/ui-automation/templates/build-adal-automation-app.yml

@@ -0,0 +1,63 @@
+parameters:


Does this template do something different from the existing template build-broker-automation-app.yml?

fadidurah · 2022-11-16T19:07:29Z

azure-pipelines/ui-automation/templates/flank/run-on-firebase-with-flank.yml

+  - name: otherFiles
+    type: string
+  - name: testsFolderName
+    type: string


This will break other pipelines if not given a default, since they are not passing in this parameter. I would suggest either adding a default value of broker-ci or fixing other pipelines that use this template as part of this same PR.

fadidurah · 2022-11-16T19:08:06Z

azure-pipelines/ui-automation/templates/run-on-firebase.yml

@@ -63,6 +65,7 @@ jobs:
              --environment-variables "clearPackageData=true" \
              --results-history-name "${{ parameters.resultsHistoryName }}" \
              --test-targets "${{ parameters.testTargetPackages }}, ${{ parameters.apiLevelTarget }}"
+            --smart-flank-gcs-path "gs://test-lab-ffz6x9pu2y62a-is0rq7a7rwdhi/smart-flank-xml/${{ project.testsFolderName }}/JUnitReport.xml"


This is not needed when running without flank.

fadidurah · 2022-11-16T19:08:38Z

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml

+  - name: firebaseDeviceAndroidVersion
+    displayName: Firebase Device Android Version
+    type: number
+    default: 28


wainaina · 2023-01-04T16:57:32Z

This is one of the pipelines I have scehduled to truncate after the full implementation of the Release pipeline as it only serves a sub function of the release pipeline.

Samuel Wainaina and others added 4 commits October 27, 2022 14:16

update display name

e4624fe

add adal automation app yml

41a355a

update variables

98a6c7d

add nightly adal automation

2747fbe

wainaina requested a review from a team as a code owner October 27, 2022 16:12

wainaina marked this pull request as draft October 27, 2022 16:13

wainaina added 4 commits October 29, 2022 03:02

utilize build-broker-automation-app.yml

596858b

fix template parameters

6bf4198

use broker repository alias

b600920

change broker app and broker flavour

a6b7e05

wainaina marked this pull request as ready for review October 29, 2022 08:48

wainaina changed the title ~~[WIP] Move the ADAL automation pipeline from IDDP to Engineering.~~ Move the ADAL automation pipeline from IDDP to Engineering Oct 29, 2022

wainaina requested review from p3dr0rv and fadidurah October 29, 2022 08:49

p3dr0rv reviewed Oct 31, 2022

View reviewed changes

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml Show resolved Hide resolved

somalaya reviewed Oct 31, 2022

View reviewed changes

azure-pipelines/ui-automation/adal-broker-BrokerHost-nightly.yml Show resolved Hide resolved

Merge branch 'master' into wainaina/move-adal-automation-pipeline

a3b2daa

wainaina requested review from somalaya and p3dr0rv November 16, 2022 16:13

p3dr0rv reviewed Nov 16, 2022

View reviewed changes

fadidurah reviewed Nov 16, 2022

View reviewed changes

fadidurah mentioned this pull request Nov 21, 2022

PROD MSAL to DEV BROKER AzureAD/microsoft-authentication-library-for-android#1716

Open

wainaina closed this Jan 4, 2023

Move the ADAL automation pipeline from IDDP to Engineering #162

Move the ADAL automation pipeline from IDDP to Engineering #162

Uh oh!

Conversation

wainaina commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wainaina commented Jan 4, 2023

Uh oh!

Uh oh!

wainaina commented Oct 27, 2022 •

edited

Loading