Edge to edge fix limited to brokered only scenarios, Fixes AB#3293334 #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restricts the edge-to-edge layout fix to brokered scenarios by checking if the app is running in a broker process before applying the flighted behavior.
- Imported
ProcessUtil. - Updated
initializeContentViewto only enable edge-to-edge handling when running in a broker process and the flight is enabled.
Comments suppressed due to low confidence (2)
common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java:66
- [nitpick] Consider adding a comment above this conditional to explain why edge-to-edge handling is limited to broker processes for better future maintainability.
if (ProcessUtil.isBrokerProcess(getApplicationContext()) && CommonFlightsManager.INSTANCE.getFlightsProvider().isFlightEnabled(CommonFlight.ENABLE_HANDLING_FOR_EDGE_TO_EDGE)) {
common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java:66
- Add unit or integration tests covering the non-broker scenario to ensure the dual-screen layout behavior remains correct when the fix isn’t applied.
if (ProcessUtil.isBrokerProcess(getApplicationContext()) && CommonFlightsManager.INSTANCE.getFlightsProvider().isFlightEnabled(CommonFlight.ENABLE_HANDLING_FOR_EDGE_TO_EDGE)) {
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
fadidurah
approved these changes
Jun 27, 2025
rpdome
approved these changes
Jun 27, 2025
somalaya
changed the title
|
✅ Work item link check complete. Description contains link AB#3293334 to an Azure Boards work item. |
somalaya
added
the
No-Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix I did in this PR is flighted #2665
But we cannot control flighting when no broker is installed. I have checked with OneAuth team and they are ok with just turning this fix ON for brokered flow since that is the majority case.
Fix : Simply limit the fix to brokered flow.
Fixes AB#3293334