Remove usage of com.nimbusds.oauth2's Token classes #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwert
reviewed
Apr 1, 2025
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/HttpResponse.java
Outdated
Show resolved
Hide resolved
billwert
approved these changes
Apr 1, 2025
bgavrilMS
reviewed
Apr 2, 2025
msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/TestHelper.java
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Apr 2, 2025
msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/TokenResponseTest.java
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes usage of several com.nimbusds.oauth2 classes, as per #909
com.nimbusds.oauth2's OIDCTokens, OIDCTokenResponse, AccessToken, and RefreshToken were removed, as well as various smaller util classes that were used with them.
To replace them, this PR does the following:
HttpResponseclass to cover the behavior of Nimbus'sHTTPResponse, and refactor it to use com.azure.json for JSON instead of com.nimbusds.oauth2TokenResponseto deal with tokens as simple Strings, rather than use Nimbus's various token-related classesTokenRequestExecutorto use MSAL Java'sHttpResponseinstead of Nimbus'sHTTPResponseNote: this PR builds off the changes made in #927, so that must be merged in first