Unicode support for DSN ODBC APIs #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
force-pushed
the
unicode-support
branch
from
668f673 to
8e49b0b
Compare
alinaliBQ
force-pushed
the
unicode-support
branch
from
8e49b0b to
14843a4
Compare
rscales
reviewed
Jun 13, 2025
cpp/src/arrow/flight/sql/odbc/flight_sql/include/flight_sql/config/configuration.h
Show resolved
Hide resolved
rscales
reviewed
Jun 13, 2025
rscales
reviewed
Jun 13, 2025
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_connection.cc
Show resolved
Hide resolved
rscales
approved these changes
Jun 16, 2025
remove comments Update connection_test.cc
Let compiler append `W` to ODBC APIs where applicable.
alinaliBQ
force-pushed
the
unicode-support
branch
from
14843a4 to
491e9ee
Compare
jduo
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wat end of applicable ODBC API namesConfigDSNtoConfigDSNW