Add MatchPhrasePrefix As Alternate Syntax for Match_Phrase_Prefix Function #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## integ-add-legacy-syntax-for-match_phrase_prefix-function #164 +/- ##
==============================================================================================
- Coverage 98.27% 95.71% -2.57%
Complexity 3351 3351
==============================================================================================
Files 327 337 +10
Lines 8457 9117 +660
Branches 553 672 +119
==============================================================================================
+ Hits 8311 8726 +415
- Misses 142 334 +192
- Partials 4 57 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acarbonetto
approved these changes
Nov 14, 2022
| The matchphraseprefix function maps to the match_phrase_prefix query used in search engine, | ||
| to return the documents that match a provided text with a given field. | ||
| It is an alternate syntax for the `match_phrase_prefix`_ function. | ||
| Available parameters include: |
|
|
||
| The matchphraseprefix function maps to the match_phrase_prefix query used in search engine, | ||
| to return the documents that match a provided text with a given field. | ||
| It is an alternate syntax for the `match_phrase_prefix`_ function. |
There was a problem hiding this comment.
Can you mention that this was added for backwards compatibility
| @@ -427,6 +427,7 @@ systemFunctionName | |||
| singleFieldRelevanceFunctionName | |||
| : MATCH | MATCH_PHRASE | MATCHPHRASE | |||
| | MATCH_BOOL_PREFIX | MATCH_PHRASE_PREFIX | |||
| | MATCHPHRASEPREFIX | |||
There was a problem hiding this comment.
nit: put MATCH_PHRASE_PREFIX and MATCHPHRASEPREFIX on the same line
|
The query Don't think we need to include this as it isn't supported in the legacy engine. |
MaxKsyunz
reviewed
Nov 14, 2022
GabeFernandez310
deleted the
dev-add-legacy-syntax-for-match_phrase_prefix-function
branch
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
* Import h3 library (#154) Made following changes to make it compatible: 1. Rename package from elasticsearch to opensearch.geospatial 2. Update License headers 3. Update build file 4. Update settings to include sub projects * Use Transport Request (#164) Remove usage of deprecated BaseNodeRequest * Update http client package to resolve build failure (#168) (#171) * Introduce H3 min resolution constant (#165) H3 version 1 has 16 resolutions, numbered 0 through 15. Introduced a constant to represent min value, similar to max value. * Add geohex aggregation (#160) This aggregation will use uber's h3 to group coordinates into H3 cell. Created new aggregation type geohex_grid. The precision will be between 0 and 15. This aggreation has default precision as 5, similar to geohash and geotile. Signed-off-by: Vijayan Balasubramanian <[email protected]> * Add integration test (#176) Included integration test for geohex_grid. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
matchphraseprefixas alternate syntax formatch_phrase_prefixfunction which currently exists in opensearchIssues Resolved
AOS-765
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.