Skip to content

Correctly infer Vertex AI base URL for location 'global' (#2014) #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

lukeramsden
Copy link

@lukeramsden lukeramsden commented Jun 7, 2025

Closes #2014


Important

Fixes base URL inference for Vertex AI 'global' location in vertex_client.rs and updates documentation in vertex.mdx.

  • Behavior:
    • Corrects base URL inference for Vertex AI when location is 'global' in vertex_client.rs.
    • Uses aiplatform.googleapis.com instead of {location}-aiplatform.googleapis.com for 'global'.
  • Documentation:
    • Updates vertex.mdx to document the base URL format for 'global' location.

This description was created by Ellipsis for d9947c3. You can customize this summary. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jun 7, 2025

@lukeramsden is attempting to deploy a commit to the Gloo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d9947c3 in 54 seconds. Click for details.
  • Reviewed 51 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/baml-runtime/src/internal/llm_client/primitive/vertex/vertex_client.rs:222
  • Draft comment:
    Handles 'global' location correctly by using the special domain. Consider normalizing the case of the location if there's any chance of mismatched casing.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. fern/03-reference/baml/clients/providers/vertex.mdx:120
  • Draft comment:
    Documentation now accurately reflects the global endpoint URL. Ensure future changes in code are mirrored here.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure future changes are mirrored in the documentation, which is a form of asking them to double-check or ensure something. This violates the rule against asking the author to ensure behavior is intended or to double-check things.

Workflow ID: wflow_Jhzlq1aF6DV6Lihv

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Vertex AI global endpoint base URL is wrong
2 participants