Skip to content

feat: Add support for alternate download locations #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielVoogsgerd
Copy link
Collaborator

@DanielVoogsgerd DanielVoogsgerd commented Apr 5, 2025

This PR introduces new functionality to branectl download services

Where services used to only support GitHub releases (and dockerhub for docker images), the input is now more freeform.

One can now for example input: github:danielvoogsgerd/brane/worker-instance:nightly to download the nightly version from my personal fork.

or in case of the default version on github these will all be synonyms:

  • worker-instance
  • worker-instance:latest
  • brane/worker-instance (or with :latest)
  • braneframework/brane/worker-instance (or with :latest)
  • github:braneframework/brane/worker-instance (or with :latest)
  • gh:braneframework/brane/worker-instance (or with :latest)

It will assume the main repo, the latest version, and github, where a field is omited

For images it also extended the support:

We should now also support GitHub container registry (ghcr.io), so we can start publishing containers there as well.

These can be downloaded using for example: ghcr:brane-api for the brane-api image, note that these images are not yet available as of yet.

There are still some things that need to be sorted out:

  • Testing of various registries and hosts
  • Regexes are incomplete for the allowable charsets
  • Aliases to get the old naming scheme back, e.g. aux, central, worker
  • Document new functionality inside the codebase and in the manual
  • Expand test suite
  • Resolve warnings (mainly functino as a reminder now)


/// Whether to download the central or the worker VMs.
#[clap(subcommand)]
kind: DownloadServicesSubcommand,
/// TODO: Enhance docs

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
}
}

// FIXME: choose right charset for all capture groups

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant